Summary: | BytecodeGenerator::initializeCapturedVariable() sets a misleading value for the 5th operand of op_put_to_scope | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, mark.lam, mmirman, msaboff, oliver, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Mark Lam
2015-01-21 14:46:39 PST
Created attachment 245095 [details]
the patch.
I need to rerun perf numbers but this patch has already passed the jsc stress tests and layout tests.
Comment on attachment 245095 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=245095&action=review > LayoutTests/js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js:11 > + // Loop ridiculously many times here to get this function to DFG compile. Can you use the predicate that dfgShouldBe uses instead? 20000 is probably much more than is necessary. Created attachment 245106 [details]
patch 2: applied Geoff's feedback
Thanks for the feedback. The test has been updated to use dfgCompiled() instead.
The perf numbers came back neutral. I'll upload the results shortly.
Created attachment 245107 [details]
perf results
Comment on attachment 245106 [details] patch 2: applied Geoff's feedback Clearing flags on attachment: 245106 Committed r178926: <http://trac.webkit.org/changeset/178926> All reviewed patches have been landed. Closing bug. |