Summary: | bmalloc: support aligned allocation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||
Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Geoffrey Garen
2015-01-21 10:50:28 PST
Created attachment 245073 [details]
Patch
Attachment 245073 [details] did not pass style-queue:
ERROR: PerformanceTests/MallocBench/MallocBench/stress_aligned.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: PerformanceTests/MallocBench/MallocBench/stress_aligned.cpp:28: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: PerformanceTests/MallocBench/MallocBench/stress_aligned.cpp:37: Bad include order. Mixing system and custom headers. [build/include_order] [4]
ERROR: PerformanceTests/MallocBench/MallocBench/stress_aligned.cpp:140: benchmark_stress_aligned is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: PerformanceTests/MallocBench/MallocBench/memalign.cpp:43: benchmark_memalign is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: PerformanceTests/MallocBench/MallocBench/stress_aligned.h:29: benchmark_stress_aligned is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 6 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 245073 [details]
Patch
r=me
Committed r178861: <http://trac.webkit.org/changeset/178861> |