Bug 140718
| Summary: | [FreeType] Calling the assignment operator from inside a copy constructor on FontPlatformDataFreeType | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | byeongha.cho |
| Component: | Text | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
byeongha.cho
Assignment operator is called on copy constructor for FontPlatformData.
It isn't a good idiom. So we need to refactor it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
(In reply to comment #0)
> It isn't a good idiom.
Why not? How would you improve it?
The copy assignment operator is not virtual, so it should be safe.
byeongha.cho
Calling the assignment operator from inside a copy constructor isn't a good idiom because the former only applies to a fully initialized object and the latter initializes a new object.
Please refer https://bugs.webkit.org/show_bug.cgi?id=136327