Bug 140709

Summary:

Web Inspector: Clean up InjectedScriptSource.js

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

burg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2015-01-20 18:17:13 PST

* SUMMARY
Clean up InjectedScriptSource.js.

1. Remove unused/stale ClosureCompiler comments
2. Simple formatting / style / logic cleanup
3. Port some fixes from Blink where they make sense

Comment 1 Radar WebKit Bug Importer 2015-01-20 18:17:24 PST

<rdar://problem/19542943>

Comment 2 Joseph Pecoraro 2015-01-20 18:31:51 PST

Created attachment 245039 [details]
[PATCH] Proposed Fix

All tests stayed the same. Did some basic testing and everything worked as expected. Including verifying the fixes.

Comment 3 WebKit Commit Bot 2015-01-20 20:22:21 PST

Comment on attachment 245039 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 245039

Committed r178796: <http://trac.webkit.org/changeset/178796>

Comment 4 WebKit Commit Bot 2015-01-20 20:22:25 PST

All reviewed patches have been landed.  Closing bug.