Bug 140701

Summary: Simplify DiagnosticLoggingClient call sites
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140463    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2015-01-20 16:26:31 PST
Simplify DiagnosticLoggingClient call sites by: - Moving the Settings::diagnosticLoggingEnabled() check inside the MainFrame::diagnosticLoggingClient() getter - Having MainFrame::diagnosticLoggingClient() return a reference instead of a pointer (returning a dummy client if necessary) Otherwise, each call site needs to both check the setting and do a null-check on the client which is a bit annoying.
Attachments
Patch (16.73 KB, patch)
2015-01-20 16:30 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-01-20 16:30:05 PST
Created attachment 245033 [details] Patch
Andreas Kling
Comment 2 2015-01-20 17:31:22 PST
Comment on attachment 245033 [details] Patch r=me
WebKit Commit Bot
Comment 3 2015-01-20 18:16:42 PST
Comment on attachment 245033 [details] Patch Clearing flags on attachment: 245033 Committed r178794: <http://trac.webkit.org/changeset/178794>
WebKit Commit Bot
Comment 4 2015-01-20 18:16:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.