Bug 140700

Summary: Identity in DFG not allocating new register.
Product: WebKit Reporter: Matthew Mirman <mmirman>
Component: JavaScriptCoreAssignee: Matthew Mirman <mmirman>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mmirman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
A testcase that fails due to this bug.
none
Made Identity in the DFG allocate a new temp register
fpizlo: review-, fpizlo: commit-queue-
Made Identity in the DFG allocate a new temp register none

Matthew Mirman
Reported 2015-01-20 15:40:40 PST
Created attachment 245029 [details] A testcase that fails due to this bug. Patch forthcoming. <rdar://problem/19339106>
Attachments
A testcase that fails due to this bug. (464 bytes, application/x-javascript)
2015-01-20 15:40 PST, Matthew Mirman 		no flags
Details
Made Identity in the DFG allocate a new temp register (1.92 KB, patch)
2015-01-20 15:47 PST, Matthew Mirman 		fpizlo: review-
fpizlo: commit-queue-
DetailsFormatted DiffDiff
Made Identity in the DFG allocate a new temp register (2.84 KB, patch)
2015-01-20 16:02 PST, Matthew Mirman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matthew Mirman
Comment 1 2015-01-20 15:47:46 PST
Created attachment 245030 [details] Made Identity in the DFG allocate a new temp register
Filip Pizlo
Comment 2 2015-01-20 15:49:19 PST
Comment on attachment 245030 [details] Made Identity in the DFG allocate a new temp register This should either reenable the test that discovered this, or write a new test. It would probably be sufficient to just reenable the skipped test. This patch should include that.
Matthew Mirman
Comment 3 2015-01-20 16:02:53 PST
Created attachment 245032 [details] Made Identity in the DFG allocate a new temp register Enabled that test case.
WebKit Commit Bot
Comment 4 2015-01-20 17:12:49 PST
Comment on attachment 245032 [details] Made Identity in the DFG allocate a new temp register Clearing flags on attachment: 245032 Committed r178788: <http://trac.webkit.org/changeset/178788>
WebKit Commit Bot
Comment 5 2015-01-20 17:12:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.