Bug 140686

Summary: Drop width / height shorthands code from StylePropertyShorthand.*
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, koivisto, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
Patch none

Chris Dumez
Reported 2015-01-20 11:10:40 PST
Drop width / height shorthands code from StylePropertyShorthand.* width / height are not shorthands for min-width/max-width and min-height/max-height. Also, only matchingCustomShorthandsForLonghand() handles those shorthands, while the reverse method (indexOfShorthandForLonghand) does not.
Attachments
WIP Patch (2.18 KB, patch)
2015-01-20 11:11 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.46 KB, patch)
2015-01-20 11:56 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-01-20 11:11:25 PST
Created attachment 245001 [details] WIP Patch
Alexis Menard (darktears)
Comment 2 2015-01-20 11:53:02 PST
Not that it counts me but r+
Chris Dumez
Comment 3 2015-01-20 11:56:26 PST
Created attachment 245007 [details] Patch
WebKit Commit Bot
Comment 4 2015-01-20 12:54:17 PST
Comment on attachment 245007 [details] Patch Clearing flags on attachment: 245007 Committed r178746: <http://trac.webkit.org/changeset/178746>
WebKit Commit Bot
Comment 5 2015-01-20 12:54:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.