Bug 14068

Summary: [S60] : stream requests are cancelled after "javascript:" execution
Product: WebKit Reporter: Mahesh Kulkarni <maheshk>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Critical CC: Sachin.Padma
Priority: P1    
Version: 523.x (Safari 3)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
URL: http://www.v28power.com/flash.htm
Attachments:
Description Flags
return after executing javascript.
Sachin.Padma: review-
attached changeLog
Sachin.Padma: review-
Attached change log with latest code
Sachin.Padma: review+
3.1 patch Sachin.Padma: review+

Mahesh Kulkarni
Reported 2007-06-11 06:35:51 PDT
Problem with requests from plugin to getUrl with "javascript" in it. After executing "javascript:" in getUrl calls of plugins, pending requests are getting canceled. This is also observed when plugin makes a request for invalid page. (i.e error page, like 404). Pending requests should not be canceled and browser should continue downloading pending requests from plugin. - Steps to reproduce: 1. www.v28power.com/flash.htm in browser. 2. Activate the flash content 3. Select any one of the tools. More Info: Please refer TSW ERR_ID: DSOA-73HB9R - Actual outcome: The tool picture enlarges and no tooltip texts are displayed. - Expected outcome: The tool picture should enlarge and tooltip text should be displayed.
Attachments
return after executing javascript. (597 bytes, patch)
2007-06-11 06:44 PDT, Mahesh Kulkarni 		Sachin.Padma: review-
DetailsFormatted DiffDiff
attached changeLog (1.12 KB, patch)
2007-06-14 06:56 PDT, Mahesh Kulkarni 		Sachin.Padma: review-
DetailsFormatted DiffDiff
Attached change log with latest code (1.08 KB, patch)
2007-06-18 05:37 PDT, Mahesh Kulkarni 		Sachin.Padma: review+
DetailsFormatted DiffDiff
3.1 patch (1.10 KB, patch)
2007-07-09 23:51 PDT, Mahesh Kulkarni 		Sachin.Padma: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mahesh Kulkarni
Comment 1 2007-06-11 06:44:41 PDT
Created attachment 14933 [details] return after executing javascript. _REASON: After Javascript execution is happened, browser continues making a get requests to resourceLoader. Invalid requests makes browser to cancel pending requests of plugin. _SOLUTION: Return from function CPluginLoader::LoadPluginContentL after execution of javascript. Even if javascript has a URL to load script engine will take care of loading the given URL. Making get request to network doesn't required when "javascript:" is present in URL. _MODULES_EFFECTED: WebKit\Plugin plugin loader _TSW ERR_ID: DSOA-73HB9R
Sachin Padma
Comment 2 2007-06-13 06:55:33 PDT
Comment on attachment 14933 [details] return after executing javascript. Please attach changelog
Mahesh Kulkarni
Comment 3 2007-06-14 06:56:56 PDT
Created attachment 15019 [details] attached changeLog
Mahesh Kulkarni
Comment 4 2007-06-14 06:57:51 PDT
Comment on attachment 15019 [details] attached changeLog Attached changeLog along with the fix.
Sachin Padma
Comment 5 2007-06-15 10:41:09 PDT
Comment on attachment 15019 [details] attached changeLog Attach changelog to the beginning. Patch does not apply. Please update your SVN workearea and recreate the patch
Mahesh Kulkarni
Comment 6 2007-06-18 05:37:55 PDT
Created attachment 15098 [details] Attached change log with latest code Attached change log with latest code
Sachin Padma
Comment 7 2007-06-21 08:04:07 PDT
Comment on attachment 15098 [details] Attached change log with latest code r=me
Sachin Padma
Comment 8 2007-06-21 08:04:42 PDT
landed in ccb in r23716
Mahesh Kulkarni
Comment 9 2007-07-09 23:51:25 PDT
Created attachment 15460 [details] 3.1 patch Branch approved.
Sachin Padma
Comment 10 2007-07-16 08:26:32 PDT
Comment on attachment 15460 [details] 3.1 patch r=me
Sachin Padma
Comment 11 2007-07-16 08:29:44 PDT
landed in 3.1m in r24315
Bradley Morrison
Comment 12 2008-04-09 11:39:25 PDT
Bulk closing of all s60 platform bugs. Sorry for the noise!
Note You need to log in before you can comment on or make changes to this bug.