| Summary: | [gstreamer] Fix expression result unused warning in GRefPtrGStreamer.cpp | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ossy, pnormand | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 244982 [details]
Patch
Is this the only fix possible? Don't we have some macro in WTF about this? (In reply to comment #2) > Is this the only fix possible? Don't we have some macro in WTF about this? I haven't found. Ok not sure it'd be worth adding anyway :) Comment on attachment 244982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244982&action=review > Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:251 > - gst_toc_ref(ptr); > + (void)gst_toc_ref(ptr); Actually we could return the result value here, return gst_toc_ref(ptr); Created attachment 244991 [details]
Patch
Comment on attachment 244991 [details] Patch Clearing flags on attachment: 244991 Committed r178711: <http://trac.webkit.org/changeset/178711> All reviewed patches have been landed. Closing bug. |
warning: ../../Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:251:9: warning: expression result unused [-Wunused-value] (GstToc*)gst_mini_object_ref(((GstMiniObject*)(ptr))); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~