Bug 140656

Summary: Sprinkle some CTTE on API::PolicyClient and API::FormClient
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Sam Weinig
Reported 2015-01-19 19:17:41 PST
Sprinkle some CTTE on API::PolicyClient and API::FormClient
Attachments
Patch (37.64 KB, patch)
2015-01-19 19:29 PST, Sam Weinig 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2015-01-19 19:29:49 PST
Created attachment 244953 [details] Patch
WebKit Commit Bot
Comment 2 2015-01-19 19:30:47 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2015-01-19 19:30:58 PST
Attachment 244953 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:271: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:334: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 4 2015-01-19 19:38:51 PST
Committed r178688: <http://trac.webkit.org/changeset/178688>
Note You need to log in before you can comment on or make changes to this bug.