| Summary: | [WK2] Stop using WKDiagnosticLoggingResultType.h C API header in Cocoa API | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | andersca, commit-queue, joepeck, mitz, sam | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Dumez
2015-01-19 19:06:07 PST
Created attachment 244963 [details]
WIP Patch
Comment on attachment 244963 [details] WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244963&action=review > Source/WebKit2/UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:45 > +- (void)_webView:(WKWebView *)webView logDiagnosticMessageWithResult:(NSString *)message description:(NSString *)description result:(_WKDiagnosticLoggingResultType)result; This breaks API compatibility unfortunately: error: conflicting parameter types in declaration of '_webView:logDiagnosticMessageWithResult:description:result:': '_WKDiagnosticLoggingResultType' vs 'WKDiagnosticLoggingResultType' (aka 'unsigned int') [-Werror,-Woverriding-method-mismatch] Any suggestion how to do the transition? I tried using "typedef NS_ENUM(uint32_t, _WKDiagnosticLoggingResultType)" above so that _WKDiagnosticLoggingResultType and WKDiagnosticLoggingResultType are typedefs to the same type but this does not seem to help... Created attachment 244967 [details]
Patch
Comment on attachment 244967 [details]
Patch
Sorry. I typed the wrong value in the ChangeLog. This patch is not related to this bug.
Created attachment 245042 [details]
Patch
Comment on attachment 245042 [details] Patch Clearing flags on attachment: 245042 Committed r178848: <http://trac.webkit.org/changeset/178848> All reviewed patches have been landed. Closing bug. |