Bug 140627 – Add iOS EWS to build.webkit.org/dashboard

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

This is necessary to easily keep track of iOS EWS health.

The code is in Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard

[Alexey Proskuryakov]

It also needs to be added to dashboard metrics page.

[David Kilzer (:ddkilzer)]

(In reply to comment #0)
> This is necessary to easily keep track of iOS EWS health.
> 
> The code is in
> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard

https://build.webkit.org/dashboard/

(In reply to comment #1)
> It also needs to be added to dashboard metrics page.

https://build.webkit.org/dashboard/metrics.html

[David Kilzer (:ddkilzer)]

Created attachment 245283 [details]
Patch v1

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> Created attachment 245283 [details]
> Patch v1

I have no clue if any of this is correct; it's the first time I've modified this code, and I'm not sure if there is a way to test this locally.

[Alexey Proskuryakov]

> I'm not sure if there is a way to test this locally.

Yes, just open the main HTML files in Safari.

[Alexey Proskuryakov]

Comment on attachment 245283 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=245283&action=review

What I see in the patch all looks right. Please test locally to make sure that all the needed pieces are in place.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:28
> +        iOS8Device: { name: "ios-8", readableName: "iOS 8", order: 5 },

So you want iOS to be the first line on the dashboard? I concur, however right now, the line is almost empty, and thus not so useful. Perhaps the right thing to do is to put it under Mac for now, and to move up once it's more complete?

[David Kilzer (:ddkilzer)]

(In reply to comment #6)
> Comment on attachment 245283 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245283&action=review
> 
> What I see in the patch all looks right. Please test locally to make sure
> that all the needed pieces are in place.

How do I do that?  I mentioned above I don't know how to test this locally.

> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:28
> > +        iOS8Device: { name: "ios-8", readableName: "iOS 8", order: 5 },
> 
> So you want iOS to be the first line on the dashboard? I concur, however
> right now, the line is almost empty, and thus not so useful. Perhaps the
> right thing to do is to put it under Mac for now, and to move up once it's
> more complete?

That's fine.

[Tim Horton]

(In reply to comment #7)
> (In reply to comment #6)
> > Comment on attachment 245283 [details]
> > Patch v1
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=245283&action=review
> > 
> > What I see in the patch all looks right. Please test locally to make sure
> > that all the needed pieces are in place.
> 
> How do I do that?  I mentioned above I don't know how to test this locally.

Comment #5 explains.

[Timothy Hatcher]

You might need to disable local file restrictions in the develop menu for it to work.

[David Kilzer (:ddkilzer)]

Committed r179144: <http://trac.webkit.org/changeset/179144>