| Summary: | [SVG -> OTF Converter] Flip the switch on | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, dino, jonlee, koivisto, ossy, simon.fraser, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 137095, 140634 | ||||||||
| Bug Blocks: | 140681 | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2015-01-17 21:28:52 PST
Created attachment 244854 [details]
Patch
Attachment 244854 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 62 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 244854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244854&action=review > Source/JavaScriptCore/ChangeLog:1 > +2015-01-17 Myles C. Maxfield <litherum@gmail.com> Wrong email. Created attachment 244873 [details]
Patch
Comment on attachment 244873 [details]
Patch
Lets do this. r=me
Comment on attachment 244873 [details] Patch Clearing flags on attachment: 244873 Committed r178653: <http://trac.webkit.org/changeset/178653> All reviewed patches have been landed. Closing bug. This broke a number of tests on Mountain Lion: <https://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r178654%20(23639)/results.html> As discussed in person, will roll out for now. Re-opened since this is blocked by bug 140634 Committed with additional Mountain Lion results in http://trac.webkit.org/changeset/178691 (In reply to comment #11) > Committed with additional Mountain Lion results in > http://trac.webkit.org/changeset/178691 It broke tests on Apple Windows bot too. before: https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/49126 after: https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/49127 bfulgham: Do you know why this is? The patch only touches LayoutTests/platform/mac* and FeatureDefines.xcconfig files. Does windows use xcconfig files somehow? (In reply to comment #13) > bfulgham: Do you know why this is? The patch only touches > LayoutTests/platform/mac* and FeatureDefines.xcconfig files. Does windows > use xcconfig files somehow? Ah, I think I got the problem: "Baseline search path: win -> mac-mountainlion -> mac -> generic" Windows use Mac results as fallback. It seems only the old results should be checked in to platform/win. (In reply to comment #14) > (In reply to comment #13) > > bfulgham: Do you know why this is? The patch only touches > > LayoutTests/platform/mac* and FeatureDefines.xcconfig files. Does windows > > use xcconfig files somehow? > > Ah, I think I got the problem: > "Baseline search path: win -> mac-mountainlion -> mac -> generic" > > Windows use Mac results as fallback. It seems only the > old results should be checked in to platform/win. Yes -- this is true. We try to reuse as much of the mac results as possible. Are these changes being made to mac-mountainlion, too? If so, I guess we need to land new baselines (i.e., copy the old mac results to win). |