Bug 140586

Summary:

Web Inspector: REGRESSION: CSS Resource appears as empty after editing it via Styles sidebar

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Jonathan Wells <jonowells>

Status:

RESOLVED FIXED

Severity:

Critical

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Animated GIF	none
[PATCH] Fix.	none
[SCREENSHOT] patched behavior 1	none
[SCREENSHOT] patched behavior 2	none
[SCREENSHOT] patched behavior 3	none

Nikita Vasilyev

Reported 2015-01-17 19:31:29 PST

Created attachment 244849 [details] Animated GIF The bug appeared so far only when inspecting the Inspector. I haven’t yet noticed the problem on any website I’ve tried. Steps to reproduce (in case you don’t like animated GIFs): 1. Inspect the inspector 2. Turn off any CSS rule by clicking a checkbox 3. Click on the corresponding CSS file link Expected: Navigate to the CSS resource with the updated content. Actual: CSS resource appears as empty.

Attachments
Animated GIF (3.04 MB, image/gif) 2015-01-17 19:31 PST, Nikita Vasilyev	no flags	Details
[PATCH] Fix. (5.79 KB, patch) 2015-02-06 12:20 PST, Jonathan Wells	no flags	Details Formatted Diff Diff
[SCREENSHOT] patched behavior 1 (119.09 KB, image/png) 2015-02-06 12:20 PST, Jonathan Wells	no flags	Details
[SCREENSHOT] patched behavior 2 (84.88 KB, image/png) 2015-02-06 12:21 PST, Jonathan Wells	no flags	Details
[SCREENSHOT] patched behavior 3 (138.69 KB, image/png) 2015-02-06 12:21 PST, Jonathan Wells	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-01-17 19:31:47 PST

<rdar://problem/19510507>

Timothy Hatcher

Comment 2 2015-01-17 19:42:45 PST

I am able to reproduce on daringfireball.net.

Timothy Hatcher

Comment 3 2015-01-17 19:43:58 PST

I wonder if this is caused by making requestContent return a Promise.

Nikita Vasilyev

Comment 4 2015-01-17 19:50:15 PST

Tried it on daringfireball.net. It worked well for a while (https://cloudup.com/cZTqauMCX88), but eventually it broke (https://cloudup.com/cVPAGPUoQCL).

Timothy Hatcher

Comment 5 2015-01-25 08:29:29 PST

Might be a regression for switching to Promises for requestConent?

Jonathan Wells

Comment 6 2015-02-06 12:20:20 PST

Created attachment 246171 [details] [PATCH] Fix.

Jonathan Wells

Comment 7 2015-02-06 12:20:48 PST

Created attachment 246172 [details] [SCREENSHOT] patched behavior 1

Jonathan Wells

Comment 8 2015-02-06 12:21:06 PST

Created attachment 246174 [details] [SCREENSHOT] patched behavior 2

Jonathan Wells

Comment 9 2015-02-06 12:21:19 PST

Created attachment 246175 [details] [SCREENSHOT] patched behavior 3

WebKit Commit Bot

Comment 10 2015-02-06 13:33:33 PST

Comment on attachment 246171 [details] [PATCH] Fix. Clearing flags on attachment: 246171 Committed r179755: <http://trac.webkit.org/changeset/179755>

WebKit Commit Bot

Comment 11 2015-02-06 13:33:37 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.