Summary: | Web Inspector: REGRESSION: CSS Resource appears as empty after editing it via Styles sidebar | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||||||
Component: | Web Inspector | Assignee: | Jonathan Wells <jonowells> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Critical | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar, Regression | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
I am able to reproduce on daringfireball.net. I wonder if this is caused by making requestContent return a Promise. Tried it on daringfireball.net. It worked well for a while (https://cloudup.com/cZTqauMCX88), but eventually it broke (https://cloudup.com/cVPAGPUoQCL). Might be a regression for switching to Promises for requestConent? Created attachment 246171 [details]
[PATCH] Fix.
Created attachment 246172 [details]
[SCREENSHOT] patched behavior 1
Created attachment 246174 [details]
[SCREENSHOT] patched behavior 2
Created attachment 246175 [details]
[SCREENSHOT] patched behavior 3
Comment on attachment 246171 [details] [PATCH] Fix. Clearing flags on attachment: 246171 Committed r179755: <http://trac.webkit.org/changeset/179755> All reviewed patches have been landed. Closing bug. |
Created attachment 244849 [details] Animated GIF The bug appeared so far only when inspecting the Inspector. I haven’t yet noticed the problem on any website I’ve tried. Steps to reproduce (in case you don’t like animated GIFs): 1. Inspect the inspector 2. Turn off any CSS rule by clicking a checkbox 3. Click on the corresponding CSS file link Expected: Navigate to the CSS resource with the updated content. Actual: CSS resource appears as empty.