Bug 140564

Summary: [Mac] Correct infinite loop in Wheel Handler code in EventHandlerMac
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Layout and RenderingAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Bug Depends on: 139914    
Bug Blocks:    
Attachments:
Description Flags
Patch dino: review+

Brent Fulgham
Reported 2015-01-16 14:17:28 PST
A bug was introduced in Bug 139914 due to a typo when converting the while() loop in the patch to a for() loop.
Attachments
Patch (1.37 KB, patch)
2015-01-16 17:31 PST, Brent Fulgham 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-01-16 14:18:07 PST
<rdar://problem/19386426>
Brent Fulgham
Comment 2 2015-01-16 17:25:16 PST
Index: mac/EventHandlerMac.mm =================================================================== --- mac/EventHandlerMac.mm (revision 178590) +++ mac/EventHandlerMac.mm (working copy) @@ -834,7 +834,7 @@ if (&frame == latchedState->frame()) return false; - for (Frame* ancestor = frame.tree().parent(); ancestor; ancestor->tree().parent()) { + for (Frame* ancestor = frame.tree().parent(); ancestor; ancestor = ancestor->tree().parent()) { if (ancestor == latchedState->frame()) return true; }
Brent Fulgham
Comment 3 2015-01-16 17:31:50 PST
Created attachment 244823 [details] Patch
Brent Fulgham
Comment 4 2015-01-16 17:49:48 PST
Committed r178617: <http://trac.webkit.org/changeset/178617>
Note You need to log in before you can comment on or make changes to this bug.