Bug 140564

Summary:

[Mac] Correct infinite loop in Wheel Handler code in EventHandlerMac

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Layout and Rendering

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Bug Depends on:

139914

Bug Blocks:

Attachments:

Description	Flags
Patch	dino: review+

Description Brent Fulgham 2015-01-16 14:17:28 PST

A bug was introduced in Bug 139914 due to a typo when converting the while() loop in the patch to a for() loop.

Comment 1 Brent Fulgham 2015-01-16 14:18:07 PST

<rdar://problem/19386426>

Comment 2 Brent Fulgham 2015-01-16 17:25:16 PST

Index: mac/EventHandlerMac.mm
===================================================================
--- mac/EventHandlerMac.mm	(revision 178590)
+++ mac/EventHandlerMac.mm	(working copy)
@@ -834,7 +834,7 @@
     if (&frame == latchedState->frame())
         return false;
 
-    for (Frame* ancestor = frame.tree().parent(); ancestor; ancestor->tree().parent()) {
+    for (Frame* ancestor = frame.tree().parent(); ancestor; ancestor = ancestor->tree().parent()) {
         if (ancestor == latchedState->frame())
             return true;
     }

Comment 3 Brent Fulgham 2015-01-16 17:31:50 PST

Created attachment 244823 [details]
Patch

Comment 4 Brent Fulgham 2015-01-16 17:49:48 PST

Committed r178617: <http://trac.webkit.org/changeset/178617>