Bug 140555

Summary:

Web Inspector: code generator should fail on duplicate parameter and member names

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Brian Burg 2015-01-16 12:11:11 PST

I accidentally ran into this, and it failed during compilation instead of specification parsing. This is an easy fix.

Comment 1 Radar WebKit Bug Importer 2015-01-16 12:11:30 PST

<rdar://problem/19502129>

Comment 2 Brian Burg 2015-01-16 12:15:20 PST

Created attachment 244785 [details]
Patch

Comment 3 WebKit Commit Bot 2015-01-16 12:16:41 PST

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

Comment 4 WebKit Commit Bot 2015-01-16 13:40:21 PST

Comment on attachment 244785 [details]
Patch

Clearing flags on attachment: 244785

Committed r178599: <http://trac.webkit.org/changeset/178599>

Comment 5 WebKit Commit Bot 2015-01-16 13:40:26 PST

All reviewed patches have been landed.  Closing bug.