Bug 140555

Summary: Web Inspector: code generator should fail on duplicate parameter and member names
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Brian Burg
Reported 2015-01-16 12:11:11 PST
I accidentally ran into this, and it failed during compilation instead of specification parsing. This is an easy fix.
Attachments
Patch (10.50 KB, patch)
2015-01-16 12:15 PST, Brian Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-01-16 12:11:30 PST
<rdar://problem/19502129>
Brian Burg
Comment 2 2015-01-16 12:15:20 PST
Created attachment 244785 [details] Patch
WebKit Commit Bot
Comment 3 2015-01-16 12:16:41 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
WebKit Commit Bot
Comment 4 2015-01-16 13:40:21 PST
Comment on attachment 244785 [details] Patch Clearing flags on attachment: 244785 Committed r178599: <http://trac.webkit.org/changeset/178599>
WebKit Commit Bot
Comment 5 2015-01-16 13:40:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.