Bug 140530

Summary: std::all_of requires complete C++ iterators in GCC 4.8
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cmarcelo, commit-queue, darin, kling, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140469    
Attachments:
Description Flags
Patch
none
Patch none

Yusuke Suzuki
Reported 2015-01-15 17:49:53 PST
std::all_of requires complete C++ iterators in GCC 4.8
Attachments
Patch (5.17 KB, patch)
2015-01-15 17:53 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (5.21 KB, patch)
2015-01-15 18:49 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2015-01-15 17:53:15 PST
Created attachment 244739 [details] Patch
Yusuke Suzuki
Comment 2 2015-01-15 18:31:57 PST
Oops, I'll fix a little
Yusuke Suzuki
Comment 3 2015-01-15 18:49:35 PST
Created attachment 244743 [details] Patch
Yusuke Suzuki
Comment 4 2015-01-15 18:50:12 PST
Updated the patch, annotating inheritance as `public`.
Csaba Osztrogonác
Comment 5 2015-01-15 23:28:05 PST
Is this bug to fix the GTK debug build break caused by 178452? ( https://bugs.webkit.org/show_bug.cgi?id=140469#c5 )
Yusuke Suzuki
Comment 6 2015-01-16 00:25:00 PST
(In reply to comment #5) > Is this bug to fix the GTK debug build break caused by 178452? > ( https://bugs.webkit.org/show_bug.cgi?id=140469#c5 ) Yeah, that's correct.
Darin Adler
Comment 7 2015-01-16 09:34:14 PST
Comment on attachment 244743 [details] Patch This looks fine to me. Are these really the only classes that need this in WebKit? It also seems that we should remove some of our own typedefs and use the ones from std::iterator as further cleanup after this.
WebKit Commit Bot
Comment 8 2015-01-16 10:15:38 PST
Comment on attachment 244743 [details] Patch Clearing flags on attachment: 244743 Committed r178581: <http://trac.webkit.org/changeset/178581>
WebKit Commit Bot
Comment 9 2015-01-16 10:15:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.