Bug 140524

Summary:

HTMLMediaElement::isPlayingAudio() returns true even when the element is explicitly muted by script

Product:

WebKit

Reporter:

Ada Chan <adachan>

Component:

Media

Assignee:

Ada Chan <adachan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jer.noble

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Ada Chan 2015-01-15 16:03:45 PST

If the media element is explicitly muted in the DOM, we should not classify it as "playing audio".

For example, there are websites that use a muted video to display an animated background, and that video element should be treated as "not playing audio".

<rdar://problem/18644403>

Comment 1 Ada Chan 2015-01-16 16:25:01 PST

Created attachment 244817 [details]
Patch

Comment 2 Andreas Kling 2015-01-17 18:53:05 PST

Comment on attachment 244817 [details]
Patch

r=me

Comment 3 Ada Chan 2015-01-19 10:51:29 PST

Thanks Andreas!

Committed:
http://trac.webkit.org/changeset/178655