Bug 140511

Summary: Reduce LayoutRect::infiniteRect() usage.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2015-01-15 13:56:38 PST 
LayoutRect/FloatRect' infinite rect representation is highly error prone. The current representation of infiniteness can only cover half of the actual range (point=(nearlyMin()/2, nearlyMin()/2) (size=(nearlyMax(), nearlyMax())). With such limitation, a FloatPoint(nearlyMax() - 1, nearlyMax() - 1) does not intersect(contain) with the infinite FloatRect.
Comment 1 zalan 2015-01-15 14:12:40 PST 
Created attachment 244712 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-01-15 14:17:42 PST 
Comment on attachment 244712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244712&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:777
> +        ASSERT(parentClipRect.isInfinite());

!parentClipRect.isInfinite()
Comment 3 zalan 2015-01-15 14:38:00 PST 
Created attachment 244715 [details]
Patch
Comment 4 zalan 2015-01-15 15:22:25 PST 
Created attachment 244717 [details]
Patch
Comment 5 WebKit Commit Bot 2015-01-15 16:11:27 PST 
Comment on attachment 244717 [details]
Patch

Clearing flags on attachment: 244717

Committed r178541: <http://trac.webkit.org/changeset/178541>
Comment 6 WebKit Commit Bot 2015-01-15 16:11:34 PST 
All reviewed patches have been landed.  Closing bug.