Bug 140511

Summary: Reduce LayoutRect::infiniteRect() usage.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2015-01-15 13:56:38 PST
LayoutRect/FloatRect' infinite rect representation is highly error prone. The current representation of infiniteness can only cover half of the actual range (point=(nearlyMin()/2, nearlyMin()/2) (size=(nearlyMax(), nearlyMax())). With such limitation, a FloatPoint(nearlyMax() - 1, nearlyMax() - 1) does not intersect(contain) with the infinite FloatRect.
Attachments
Patch (9.83 KB, patch)
2015-01-15 14:12 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (9.46 KB, patch)
2015-01-15 14:38 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (9.31 KB, patch)
2015-01-15 15:22 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2015-01-15 14:12:40 PST
Created attachment 244712 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-01-15 14:17:42 PST
Comment on attachment 244712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244712&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:777 > + ASSERT(parentClipRect.isInfinite()); !parentClipRect.isInfinite()
alan
Comment 3 2015-01-15 14:38:00 PST
Created attachment 244715 [details] Patch
alan
Comment 4 2015-01-15 15:22:25 PST
Created attachment 244717 [details] Patch
WebKit Commit Bot
Comment 5 2015-01-15 16:11:27 PST
Comment on attachment 244717 [details] Patch Clearing flags on attachment: 244717 Committed r178541: <http://trac.webkit.org/changeset/178541>
WebKit Commit Bot
Comment 6 2015-01-15 16:11:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.