Summary: | Rename SimpleFontData to Font | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||||||||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||
Severity: | Normal | CC: | commit-queue, darin, hyatt, mitz, mmaxfield | ||||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||
Bug Depends on: | 140814 | ||||||||||||||||||||||||
Bug Blocks: | 135290 | ||||||||||||||||||||||||
Attachments: |
|
Description
Antti Koivisto
2015-01-15 07:34:11 PST
Created attachment 244701 [details]
patch
Created attachment 244703 [details]
patch
Attachment 244703 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:49: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:142: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:256: Missing spaces around / [whitespace/operators] [3]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:336: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:337: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:337: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:338: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:338: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/FontMac.mm:339: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/ios/FontIOS.mm:53: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/ios/FontIOS.mm:54: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/Font.h:29: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/Font.h:143: The parameter name "glyph" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:235: The parameter name "glyph" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:236: The parameter name "glyph" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:240: The parameter name "glyph" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:258: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:139: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:193: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:253: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/graphics/mac/FontCascadeComplexTextMac.cpp:85: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/mac/FontCascadeMac.mm:209: Missing space before ( in switch( [whitespace/parens] [5]
Total errors found: 22 in 90 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 244703 [details]
patch
I approve of the idea, but since EWS is all red, seems like you should upload a rebased one.
Created attachment 245097 [details]
patch
Attachment 245097 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/Font.h:29: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/Font.h:143: The parameter name "glyph" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:235: The parameter name "glyph" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:236: The parameter name "glyph" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:240: The parameter name "glyph" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:258: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:139: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:193: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:253: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 9 in 82 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 245118 [details]
another
Attachment 245118 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/Font.h:29: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/Font.h:143: The parameter name "glyph" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:235: The parameter name "glyph" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:236: The parameter name "glyph" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:240: The parameter name "glyph" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:258: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:139: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:193: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:253: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 9 in 88 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 245119 [details]
another
Created attachment 245147 [details]
another
Attachment 245147 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/win/UniscribeController.h:59: The parameter name "item" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontWin.cpp:29: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/cairo/FontCairo.cpp:36: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCGWin.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCacheWin.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 6 in 118 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 245148 [details]
another
Attachment 245148 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontWin.cpp:29: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/cairo/FontCairo.cpp:36: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCGWin.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCacheWin.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 5 in 119 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 245149 [details]
another
Attachment 245149 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontWin.cpp:29: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/cairo/FontCairo.cpp:36: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCGWin.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCacheWin.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 5 in 119 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 245151 [details]
another
Attachment 245151 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontWin.cpp:29: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/cairo/FontCairo.cpp:36: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCGWin.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCacheWin.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 5 in 119 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 245156 [details]
another
Attachment 245156 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontWin.cpp:29: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/cairo/FontCairo.cpp:36: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCGWin.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/win/FontCacheWin.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 5 in 119 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|