Summary: | REGRESSION(r177876): Membuster regressed ~4% | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, kling, mmaxfield | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antti Koivisto
2015-01-15 06:41:34 PST
Created attachment 244692 [details]
patch
Comment on attachment 244692 [details]
patch
r=me
That didn't fix it. Created attachment 245002 [details]
patch
Comment on attachment 245002 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=245002&action=review r=me > Source/WebCore/platform/graphics/FontCascade.cpp:296 > Vector<unsigned, 50> toRemove; > - FontGlyphsCache::iterator end = fontGlyphsCache().end(); > - for (FontGlyphsCache::iterator it = fontGlyphsCache().begin(); it != end; ++it) { > - if (it->value->glyphs.get().hasOneRef()) > - toRemove.append(it->key); > + for (auto& entry : fontGlyphsCache()) { > + if (entry.value->glyphs.get().hasOneRef()) > + toRemove.append(entry.key); > } > for (unsigned i = 0; i < toRemove.size(); ++i) > fontGlyphsCache().remove(toRemove[i]); Jesus man, just use removeIf(), it's not 2014 anymore. |