Bug 140469

Summary: Switch VisitedLinkProvider over to WebProcessLifetimeObserver
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: REOPENED    
Severity: Normal CC: cgarcia, clopez, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=140504
Bug Depends on: 140530    
Bug Blocks:    
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2015-01-14 14:57:54 PST
Switch VisitedLinkProvider over to WebProcessLifetimeObserver
Attachments
Patch (11.37 KB, patch)
2015-01-14 14:58 PST, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-01-14 14:58:48 PST
Created attachment 244645 [details] Patch
Andreas Kling
Comment 2 2015-01-14 15:11:31 PST
Comment on attachment 244645 [details] Patch r=me
Andreas Kling
Comment 3 2015-01-14 15:11:50 PST
Comment on attachment 244645 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244645&action=review > Source/WebKit2/UIProcess/WebProcessLifetimeObserver.h:49 > + WTF::IteratorRange<HashCountedSet<WebProcessProxy*>::iterator::Keys> processes(); I'd have made this const.
Anders Carlsson
Comment 4 2015-01-14 15:18:28 PST
Committed r178452: <http://trac.webkit.org/changeset/178452>
Csaba Osztrogonác
Comment 5 2015-01-14 15:45:17 PST
Comment on attachment 244645 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244645&action=review > Source/WebKit2/UIProcess/WebProcessLifetimeObserver.cpp:66 > + ASSERT(std::all_of(m_processes.begin().keys(), m_processes.end().keys(), [](WebProcessProxy* process) { It broke the GTK debug build. https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/47766
Csaba Osztrogonác
Comment 6 2015-01-16 00:51:30 PST
new bug report to fix the build failure: bug140530
Mark Rowe (bdash)
Comment 7 2015-01-19 19:46:45 PST
I rolled this out in r178690 as this change broke visited link coloring in all but the first web process.
Note You need to log in before you can comment on or make changes to this bug.