| Summary: | Switch VisitedLinkProvider over to WebProcessLifetimeObserver | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | REOPENED --- | ||||||
| Severity: | Normal | CC: | cgarcia, clopez, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=140504 | ||||||
| Bug Depends on: | 140530 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2015-01-14 14:57:54 PST
Created attachment 244645 [details]
Patch
Comment on attachment 244645 [details]
Patch
r=me
Comment on attachment 244645 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244645&action=review > Source/WebKit2/UIProcess/WebProcessLifetimeObserver.h:49 > + WTF::IteratorRange<HashCountedSet<WebProcessProxy*>::iterator::Keys> processes(); I'd have made this const. Committed r178452: <http://trac.webkit.org/changeset/178452> Comment on attachment 244645 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244645&action=review > Source/WebKit2/UIProcess/WebProcessLifetimeObserver.cpp:66 > + ASSERT(std::all_of(m_processes.begin().keys(), m_processes.end().keys(), [](WebProcessProxy* process) { It broke the GTK debug build. https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/47766 new bug report to fix the build failure: bug140530 |