When building the NFA of the global disjunction, share the prefix subgraph of existing subpatterns

• Component: New Bugs
• Status: RESOLVED FIXED

[Benjamin Poulain]

When building the NFA of the global disjunction, share the prefix subgraph of existing subpatterns

[Benjamin Poulain]

Created attachment 244642 [details]
Patch

[Andreas Kling]

Comment on attachment 244642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244642&action=review

r=me

> Source/WebCore/contentextensions/DFANode.h:47
> -    Vector<unsigned> correspondingDFANodes;
> +    Vector<unsigned> correspondingNFANodes;

Oops :)

> Source/WebCore/contentextensions/URLFilterParser.cpp:42
> +static TrivialAtom trivialAtomFromAsciiCharacter(char character)

I think we typically capitalize "ASCII" even in this kind of context.

> Source/WebCore/contentextensions/URLFilterParser.cpp:55
> +static void quantifyTrivialAtom(TrivialAtom& trivialTom, TrivialAtomQuantifier quantifier)

trivialTom -> trivialAtom

> Source/WebCore/contentextensions/URLFilterParser.cpp:317
> +            auto addResult = m_LastPrefixTreeEntry->nextPattern.set(m_pendingTrivialAtom, WTF::move(nextPrefixTreeEntry));

I guess you wanted add() here, not set()?

> Source/WebCore/contentextensions/URLFilterParser.cpp:337
> +    PrefixTreeEntry* m_LastPrefixTreeEntry;

Camel casing error, should be m_lastPrefixTreeEntry.

> Source/WebCore/contentextensions/URLFilterParser.h:50
> +    URLFilterParser(NFA&);

explicit

[Benjamin Poulain]

Committed r178529: <http://trac.webkit.org/changeset/178529>