| Summary: | Correct calculation of 16-bit text iterator decode offsets | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
| Component: | WebCore Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | bfulgham | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Brent Fulgham
2015-01-13 20:49:54 PST
Created attachment 244576 [details]
Patch
I misunderstood what copyASCIIMachineWord was doing here. The sizeof() is the correct thing to be doing, and the Static Analyzer warning is spurious. Comment on attachment 244576 [details]
Patch
These three fixes look good. Why no regression tests for any of them? Didn’t these bugs cause any symptoms? We normally require regression tests for all bug fixes.
Comment on attachment 244576 [details]
Patch
Oops, as you said, the warning was wrong for the destination16 lines!
|