Bug 140424

Summary: [EFL] Fix build after r178390
Product: WebKit Reporter: Hunseop Jeong <hs85.jeong>
Component: WebKit EFLAssignee: Hunseop Jeong <hs85.jeong>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cdumez, commit-queue, dino, gyuyoung.kim, lucas.de.marchi, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 140431    
Bug Blocks: 126408    
Attachments:
Description Flags
Patch
none
Patch none

Hunseop Jeong
Reported 2015-01-13 19:59:15 PST
lib/../Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/JSWebGL1RenderingContext.cpp.o: In function `WebCore::JSWebGL1RenderingContext::visitChildren(JSC::JSCell*, JSC::SlotVisitor&)': JSWebGL1RenderingContext.cpp:(.text._ZN7WebCore24JSWebGL1RenderingContext13visitChildrenEPN3JSC6JSCellERNS1_11SlotVisitorE+0x16): undefined reference to `WebCore::JSWebGL1RenderingContext::visitAdditionalChildren(JSC::SlotVisitor&)' lib/../Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/JSWebGL2RenderingContext.cpp.o: In function `WebCore::JSWebGL2RenderingContext::visitChildren(JSC::JSCell*, JSC::SlotVisitor&)': JSWebGL2RenderingContext.cpp:(.text._ZN7WebCore24JSWebGL2RenderingContext13visitChildrenEPN3JSC6JSCellERNS1_11SlotVisitorE+0x16): undefined reference to `WebCore::JSWebGL2RenderingContext::visitAdditionalChildren(JSC::SlotVisitor&)'
Attachments
Patch (1.20 KB, patch)
2015-01-13 20:25 PST, Hunseop Jeong 		no flags
DetailsFormatted DiffDiff
Patch (1.77 KB, patch)
2015-01-13 20:56 PST, Hunseop Jeong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hunseop Jeong
Comment 1 2015-01-13 20:25:37 PST
Created attachment 244573 [details] Patch
WebKit Commit Bot
Comment 2 2015-01-13 20:28:08 PST
Attachment 244573 [details] did not pass style-queue: ERROR: Source/WebCore/CMakeLists.txt:1151: Alphabetical sorting problem. "css/CSSKeyframeRule.cpp" should be before "css/WebKitCSSResourceValue.cpp". [list/order] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Hunseop Jeong
Comment 3 2015-01-13 20:41:45 PST
ERROR: Source/WebCore/CMakeLists.txt:1151: Alphabetical sorting problem. "css/CSSKeyframeRule.cpp" should be before "css/WebKitCSSResourceValue.cpp". [list/order] [5] This style check error isn't related with this issue. I will fix it after this issue.
Hunseop Jeong
Comment 4 2015-01-13 20:56:48 PST
Created attachment 244578 [details] Patch
Hunseop Jeong
Comment 5 2015-01-13 21:06:36 PST
Comment on attachment 244578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244578&action=review > Source/WebCore/CMakeLists.txt:-1280 > - css/CSSKeyframesRule.cpp This files isn't related with this issue but style check failed here. So I moved files to fix the Alphabetical sorting problem.
Csaba Osztrogonác
Comment 6 2015-01-13 23:29:52 PST
Comment on attachment 244578 [details] Patch Clearing flags on attachment: 244578 Committed r178410: <http://trac.webkit.org/changeset/178410>
Csaba Osztrogonác
Comment 7 2015-01-13 23:30:02 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 8 2015-01-14 00:06:26 PST
Re-opened since this is blocked by bug 140431
Hunseop Jeong
Comment 9 2015-01-18 22:23:28 PST
Unreviewed, rolling out r178390, r178392, r178398, r178400, r178402, and r178410
Note You need to log in before you can comment on or make changes to this bug.