Summary: | [EFL] Fix build after r178390 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hunseop Jeong <hs85.jeong> | ||||||
Component: | WebKit EFL | Assignee: | Hunseop Jeong <hs85.jeong> | ||||||
Status: | RESOLVED WONTFIX | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, dino, gyuyoung.kim, lucas.de.marchi, ossy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 140431 | ||||||||
Bug Blocks: | 126408 | ||||||||
Attachments: |
|
Description
Hunseop Jeong
2015-01-13 19:59:15 PST
Created attachment 244573 [details]
Patch
Attachment 244573 [details] did not pass style-queue:
ERROR: Source/WebCore/CMakeLists.txt:1151: Alphabetical sorting problem. "css/CSSKeyframeRule.cpp" should be before "css/WebKitCSSResourceValue.cpp". [list/order] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
ERROR: Source/WebCore/CMakeLists.txt:1151: Alphabetical sorting problem. "css/CSSKeyframeRule.cpp" should be before "css/WebKitCSSResourceValue.cpp". [list/order] [5] This style check error isn't related with this issue. I will fix it after this issue. Created attachment 244578 [details]
Patch
Comment on attachment 244578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244578&action=review > Source/WebCore/CMakeLists.txt:-1280 > - css/CSSKeyframesRule.cpp This files isn't related with this issue but style check failed here. So I moved files to fix the Alphabetical sorting problem. Comment on attachment 244578 [details] Patch Clearing flags on attachment: 244578 Committed r178410: <http://trac.webkit.org/changeset/178410> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 140431 |