Bug 140414

Summary:

Convert WebUserContentControllerProxy to an API::Object bridged to WKUserContentController

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

140429, 140432

Bug Blocks:

Attachments:

Description	Flags
Patch	mitz: review+

Description Sam Weinig 2015-01-13 15:04:44 PST

Convert WebUserContentControllerProxy to an API::Object bridged to WKUserContentController

Comment 1 Sam Weinig 2015-01-13 15:06:43 PST

Created attachment 244552 [details]
Patch

Comment 2 Sam Weinig 2015-01-13 15:35:17 PST

Committed r178385: <http://trac.webkit.org/changeset/178385>

Comment 3 Chris Dumez 2015-01-13 18:35:42 PST

Seems to have broken GTK build:
Last 500 characters of output:
rocess/API/gtk/WebKitUserContentManager.cpp
../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp: In constructor '_WebKitUserContentManagerPrivate::_WebKitUserContentManagerPrivate()':
../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp:37:33: error: 'create' is not a member of 'WebKit::WebUserContentControllerProxy'
         : userContentController(WebUserContentControllerProxy::create())
                                 ^
ninja: build stopped: subcommand failed.

Comment 4 WebKit Commit Bot 2015-01-14 02:11:56 PST

Re-opened since this is blocked by bug 140432