Bug 140414

Summary: Convert WebUserContentControllerProxy to an API::Object bridged to WKUserContentController
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 140429, 140432    
Bug Blocks:    
Attachments:
Description Flags
Patch mitz: review+

Sam Weinig
Reported 2015-01-13 15:04:44 PST
Convert WebUserContentControllerProxy to an API::Object bridged to WKUserContentController
Attachments
Patch (6.91 KB, patch)
2015-01-13 15:06 PST, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2015-01-13 15:06:43 PST
Created attachment 244552 [details] Patch
Sam Weinig
Comment 2 2015-01-13 15:35:17 PST
Committed r178385: <http://trac.webkit.org/changeset/178385>
Chris Dumez
Comment 3 2015-01-13 18:35:42 PST
Seems to have broken GTK build: Last 500 characters of output: rocess/API/gtk/WebKitUserContentManager.cpp ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp: In constructor '_WebKitUserContentManagerPrivate::_WebKitUserContentManagerPrivate()': ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp:37:33: error: 'create' is not a member of 'WebKit::WebUserContentControllerProxy' : userContentController(WebUserContentControllerProxy::create()) ^ ninja: build stopped: subcommand failed.
WebKit Commit Bot
Comment 4 2015-01-14 02:11:56 PST
Re-opened since this is blocked by bug 140432
Note You need to log in before you can comment on or make changes to this bug.