Bug 140410 – [WK2][iOS] Add Cocoa delegate for logging diagnostic messages

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Add Cocoa delegate for logging diagnostic messages. Right now, there is only a WK2 C API client.

[Chris Dumez]

Created attachment 244630 [details]
Patch

[Chris Dumez]

Created attachment 244634 [details]
Patch

[Sam Weinig]

Unless we really need this code to run in the WebProcess, I would rather we IPC this over to the UIProcess and do it there.

[Chris Dumez]

Created attachment 244751 [details]
Patch

[Chris Dumez]

Created attachment 244777 [details]
Patch

[Chris Dumez]

Sam, could you please take another look? I updated the patch now that diagnostic messages go through the UIProcess.

[Anders Carlsson]

Comment on attachment 244777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244777&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:38
> +- (void)_webView:(WKWebView *)webView logDiagnosticMessage:(NSString *)message inDescription:(NSString *)description;
> +- (void)_webView:(WKWebView *)webView logDiagnosticMessageWithResult:(NSString *)message inDescription:(NSString *)description inResult:(WKDiagnosticLoggingResultType)result;
> +- (void)_webView:(WKWebView *)webView logDiagnosticMessageWithValue:(NSString *)message inDescription:(NSString *)description inValue:(NSString *) value;

I think these read a little weird, especially the "inDescription" and "inValue" parts.

[Chris Dumez]

Created attachment 244796 [details]
Patch

[Chris Dumez]

(In reply to comment #7)
> Comment on attachment 244777 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244777&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:38
> > +- (void)_webView:(WKWebView *)webView logDiagnosticMessage:(NSString *)message inDescription:(NSString *)description;
> > +- (void)_webView:(WKWebView *)webView logDiagnosticMessageWithResult:(NSString *)message inDescription:(NSString *)description inResult:(WKDiagnosticLoggingResultType)result;
> > +- (void)_webView:(WKWebView *)webView logDiagnosticMessageWithValue:(NSString *)message inDescription:(NSString *)description inValue:(NSString *) value;
> 
> I think these read a little weird, especially the "inDescription" and
> "inValue" parts.

Ok, I am really not familiar with ObjC and its conventions. I switched to description/value/result instead of inDescription/inValue/inResult. Let me know if you have other suggestions so that these read better.

[WebKit Commit Bot]

Comment on attachment 244796 [details]
Patch

Clearing flags on attachment: 244796

Committed r178630: <http://trac.webkit.org/changeset/178630>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.