Summary: | Make WTF::Optional work with msvc 2013 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | Web Template Framework | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, benjamin, cmarcelo, commit-queue, darin, sam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 140347 | ||||||||
Attachments: |
|
Description
Chris Dumez
2015-01-13 11:45:14 PST
Created attachment 244531 [details]
Patch
Comment on attachment 244531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244531&action=review > Source/WTF/wtf/Optional.h:65 > + new (&m_value) T(*other.asPtr()); I still think you want NotNull here. > Source/WTF/wtf/Optional.h:72 > + new (&m_value) T(WTF::move(*other.asPtr())); I still think you want NotNull here. > Source/WTF/wtf/Optional.h:78 > + new (&m_value) T(WTF::move(value)); NotNull. > Source/WTF/wtf/Optional.h:85 > + new (&m_value) T(std::forward<Args>(args)...); NotNull. > Source/WTF/wtf/Optional.h:106 > + new (&m_value) T(*other.asPtr()); NotNull. > Source/WTF/wtf/Optional.h:-138 > - template<typename U> > - Optional& operator=(U&& u) What happened to this overload? > Source/WTF/wtf/Optional.h:119 > + new (&m_value) T(WTF::move(*other.asPtr())); NotNull. Created attachment 244535 [details]
Patch
Comment on attachment 244531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244531&action=review >> Source/WTF/wtf/Optional.h:65 >> + new (&m_value) T(*other.asPtr()); > > I still think you want NotNull here. Right, done. >> Source/WTF/wtf/Optional.h:-138 >> - Optional& operator=(U&& u) > > What happened to this overload? I had trouble getting it to build initially and forgot to add it back. It is back in. Comment on attachment 244535 [details] Patch Clearing flags on attachment: 244535 Committed r178372: <http://trac.webkit.org/changeset/178372> All reviewed patches have been landed. Closing bug. |