Summary: | Devirtualize FontData | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, mmaxfield | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antti Koivisto
2015-01-13 08:22:46 PST
Created attachment 244515 [details]
patch
Created attachment 244519 [details]
patch
Comment on attachment 244519 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=244519&action=review r=me > Source/WebCore/css/CSSSegmentedFontFace.cpp:126 > + unsigned size = m_fontFaces.size(); > + for (unsigned i = 0; i < size; i++) { Range for? > Source/WebCore/platform/graphics/FontRanges.h:47 > + PassRefPtr<SimpleFontData> fontData() const { return m_fontData; } This should return RefPtr (or Ref.) > Source/WebCore/platform/graphics/FontRanges.h:57 > + static PassRefPtr<SegmentedFontData> create() { return adoptRef(new SegmentedFontData); } This should return Ref.
> > Source/WebCore/platform/graphics/FontRanges.h:47
> > + PassRefPtr<SimpleFontData> fontData() const { return m_fontData; }
>
> This should return RefPtr (or Ref.)
>
> > Source/WebCore/platform/graphics/FontRanges.h:57
> > + static PassRefPtr<SegmentedFontData> create() { return adoptRef(new SegmentedFontData); }
>
> This should return Ref.
This is just the move of a move-edit. The edit part fixed these.
May have broken the build: /Volumes/Data/EWS/WebKit/Source/WebCore/platform/graphics/mac/FontComplexTextMac.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/FontComplexTextMac.o /Volumes/Data/EWS/WebKit/Source/WebCore/platform/graphics/mac/FontComplexTextMac.cpp:141:47: error: no member named 'isEmpty' in 'WebCore::FontRanges' for (unsigned i = 0; !fallbackRangesAt(i).isEmpty(); ++i) { ~~~~~~~~~~~~~~~~~~~ ^ 1 error generated. (In reply to comment #6) > May have broken the build: > /Volumes/Data/EWS/WebKit/Source/WebCore/platform/graphics/mac/ > FontComplexTextMac.cpp -o > /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/ > Objects-normal/x86_64/FontComplexTextMac.o > /Volumes/Data/EWS/WebKit/Source/WebCore/platform/graphics/mac/ > FontComplexTextMac.cpp:141:47: error: no member named 'isEmpty' in > 'WebCore::FontRanges' > for (unsigned i = 0; !fallbackRangesAt(i).isEmpty(); ++i) { > ~~~~~~~~~~~~~~~~~~~ ^ > 1 error generated. Build fix landed in <http://trac.webkit.org/changeset/178389>. Seems to have broken IOS build with errors like these: Source/WebKit/ios/Misc/EmojiFallbackFontSelector.h:36:24: error: no member named 'FontData' in namespace 'WebCore'; did you mean 'WebCore::GlyphData::fontData' Another iOS build fix was landed in <https://trac.webkit.org/r178389>. |