Summary: | Basic block start offsets should never be larger than end offsets in the control flow profiler | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 138454 | ||||||||
Attachments: |
|
Description
Saam Barati
2015-01-12 17:03:43 PST
This patch is actually turning into a fix that allows a single textual JavaScript statement to have its AST node instructions emitted multiple times and to not mess up the control flow profiler's computation of basic block boundaries. *** Bug 139287 has been marked as a duplicate of this bug. *** Created attachment 244705 [details]
patch
Attachment 244705 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:4082: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 244952 [details]
patch (check build)
making sure it builds everywhere
Attachment 244952 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:4082: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
landed in: http://trac.webkit.org/changeset/178692 |