Bug 140356

Summary: [EFL] Fix libseccomp dependency
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cgarcia, gyuyoung.kim, mcatanzaro, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2015-01-12 06:55:15 PST
The problem is that building of many source files should depend on the generated include/seccomp.h , but they don't. The bug is already fixed in libseccomp: http://sourceforge.net/p/libseccomp/libseccomp/ci/3b6b69184196189d3b53ae695c0d130b9cf70784/ I propose adding this fix to jhbuild patches. (note: It causes build error during cross compiling when generating of include/seccomp.h is very very slow. ) error log: ----------- >> INFO: building in directory include/ ... >> INFO: building in directory src/ ... GEN seccomp.h In file included from api.c:32:0: /home/webkit/WebKit/WebKitBuild/DependenciesEFL/Source/libseccomp-2.1.0/include/seccomp.h:407:1: error: unterminated comment /** ^ In file included from api.c:32:0: ...
Attachments
Patch (2.24 KB, patch)
2015-01-12 06:56 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-01-12 06:56:04 PST
Created attachment 244444 [details] Patch
Michael Catanzaro
Comment 2 2015-01-12 07:00:03 PST
I would update to 2.1.1 (which should include that fix) instead of building from an older git snapshot. You can copy the moduleset change from the very bottom of https://bugs.webkit.org/attachment.cgi?id=243959&action=prettypatch
Csaba Osztrogonác
Comment 3 2015-01-12 07:09:39 PST
(In reply to comment #2) > I would update to 2.1.1 (which should include that fix) instead of building > from an older git snapshot. > > You can copy the moduleset change from the very bottom of > https://bugs.webkit.org/attachment.cgi?id=243959&action=prettypatch Good point, let's bump instead of cherry picking: bug140357
Note You need to log in before you can comment on or make changes to this bug.