Bug 140346

Summary: Enable Vector bounds checking for ElementDescendantIterator.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, esprehn+autocc, kangil.han, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=154477
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2015-01-11 19:22:17 PST
I had originally disabled Vector bounds checking for ElementDescendantIterator's internal ancestor stack, but upon re-running performance benchmarks, it appears to have little-to-no measurable benefit. Let's add it back.
Attachments
Patch (1.31 KB, patch)
2015-01-11 19:24 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-01-11 19:24:10 PST
Created attachment 244430 [details] Patch
Alexey Proskuryakov
Comment 2 2015-01-11 20:12:49 PST
Thank you!
WebKit Commit Bot
Comment 3 2015-01-11 20:33:38 PST
Comment on attachment 244430 [details] Patch Clearing flags on attachment: 244430 Committed r178253: <http://trac.webkit.org/changeset/178253>
WebKit Commit Bot
Comment 4 2015-01-11 20:33:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.