Bug 140346

Summary:

Enable Vector bounds checking for ElementDescendantIterator.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

DOM

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, esprehn+autocc, kangil.han, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=154477

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2015-01-11 19:22:17 PST

I had originally disabled Vector bounds checking for ElementDescendantIterator's internal ancestor stack, but upon re-running performance benchmarks, it appears to have little-to-no measurable benefit.

Let's add it back.

Comment 1 Andreas Kling 2015-01-11 19:24:10 PST

Created attachment 244430 [details]
Patch

Comment 2 Alexey Proskuryakov 2015-01-11 20:12:49 PST

Thank you!

Comment 3 WebKit Commit Bot 2015-01-11 20:33:38 PST

Comment on attachment 244430 [details]
Patch

Clearing flags on attachment: 244430

Committed r178253: <http://trac.webkit.org/changeset/178253>

Comment 4 WebKit Commit Bot 2015-01-11 20:33:43 PST

All reviewed patches have been landed.  Closing bug.