Bug 140336

Summary: REGRESSION(r178029): [GTK][EFL] Caused no-backing-for-clip-overlap test failures
Product: WebKit Reporter: Byungseon(Sun) Shin <sun.shin>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, mrobinson, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 138551    
Attachments:
Description Flags
Patch
none
Error Capture after r178029
none
Expected Result
none
Patch
none
Patch none

Description Byungseon(Sun) Shin 2015-01-10 05:43:36 PST 
Revision r178176: <http://trac.webkit.org/changeset/178176> caused no-backing-for-clip-overlap test failures on GTK Platform.

The following test is failing on platform GTK:
compositing/backing/no-backing-for-clip-overlap.html
Comment 1 Byungseon(Sun) Shin 2015-01-10 06:01:54 PST 
Created attachment 244408 [details]
Patch
Comment 2 Byungseon(Sun) Shin 2015-01-10 06:09:13 PST 
Created attachment 244409 [details]
Error Capture after r178029
Comment 3 Byungseon(Sun) Shin 2015-01-10 06:10:49 PST 
Created attachment 244410 [details]
Expected Result
Comment 4 Gyuyoung Kim 2015-01-10 23:01:38 PST 
Comment on attachment 244408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244408&action=review

> Source/WebCore/ChangeLog:3
> +        [GTK] Fix regression introduced in r178029

It seems this patch is not only for [GTK] port.
Comment 5 Gyuyoung Kim 2015-01-10 23:05:03 PST 
Comment on attachment 244408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244408&action=review

>> Source/WebCore/ChangeLog:3
>> +        [GTK] Fix regression introduced in r178029
> 
> It seems this patch is not only for [GTK] port.

Besides this title differs from Bugzilla title.

REGRESSION(r178029): [GTK] Caused no-backing-for-clip-overlap test failures
Comment 6 Byungseon(Sun) Shin 2015-01-11 04:40:56 PST 
Created attachment 244422 [details]
Patch
Comment 7 Byungseon(Sun) Shin 2015-01-11 04:42:49 PST 
Comment on attachment 244408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244408&action=review

>>> Source/WebCore/ChangeLog:3
>>> +        [GTK] Fix regression introduced in r178029
>> 
>> It seems this patch is not only for [GTK] port.
> 
> Besides this title differs from Bugzilla title.
> 
> REGRESSION(r178029): [GTK] Caused no-backing-for-clip-overlap test failures

Thanks for the review. I have updated ChangeLog.
Comment 8 Simon Fraser (smfr) 2015-01-12 15:38:12 PST 
Comment on attachment 244422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244422&action=review

> Source/WebCore/ChangeLog:8
> +        Creating childClippingMaskLayer when renderer has border radius or clip path.

Avoid creating...?
Comment 9 Byungseon(Sun) Shin 2015-01-12 15:51:15 PST 
Created attachment 244474 [details]
Patch
Comment 10 WebKit Commit Bot 2015-01-12 16:35:25 PST 
Comment on attachment 244474 [details]
Patch

Clearing flags on attachment: 244474

Committed r178308: <http://trac.webkit.org/changeset/178308>
Comment 11 WebKit Commit Bot 2015-01-12 16:35:31 PST 
All reviewed patches have been landed.  Closing bug.