Bug 140298

Summary:

[Cocoa] Make decoded image data purgeable ASAP.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Images

Assignee:

Andreas Kling <kling>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

ap, bfulgham, commit-queue, kling, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=140309

Bug Depends on:

141132, 141395

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion	none

Andreas Kling

Reported 2015-01-09 10:41:22 PST

Patch forthcoming.

Attachments
Patch (3.16 KB, patch) 2015-01-09 10:43 PST, Andreas Kling	no flags	Details Formatted Diff Diff
Patch for landing (3.42 KB, patch) 2015-01-09 11:15 PST, Andreas Kling	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion (582.99 KB, application/zip) 2015-01-09 11:52 PST, WebKit Commit Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2015-01-09 10:43:20 PST

Created attachment 244350 [details] Patch

Antti Koivisto

Comment 2 2015-01-09 11:04:09 PST

Comment on attachment 244350 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244350&action=review > Source/WebCore/ChangeLog:23 > + Note that the worst-possible case would be something like > + Seems like you failed to complete the

Andreas Kling

Comment 3 2015-01-09 11:15:02 PST

Created attachment 244353 [details] Patch for landing

WebKit Commit Bot

Comment 4 2015-01-09 11:52:09 PST

Comment on attachment 244353 [details] Patch for landing Rejecting attachment 244353 [details] from commit-queue. New failing tests: css3/background/background-repeat-space-content.html Full output: http://webkit-queues.appspot.com/results/6083475790626816

WebKit Commit Bot

Comment 5 2015-01-09 11:52:11 PST

Created attachment 244358 [details] Archive of layout-test-results from webkit-cq-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Andreas Kling

Comment 6 2015-01-09 12:07:14 PST

Comment on attachment 244353 [details] Patch for landing Clearing flags on attachment: 244353 Committed r178183: <http://trac.webkit.org/changeset/178183>

Andreas Kling

Comment 7 2015-01-09 12:07:18 PST

All reviewed patches have been landed. Closing bug.

Brent Fulgham

Comment 8 2015-01-09 17:30:35 PST

May have caused 1 test failure on the bots (may be a simple rebaseline): https://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r178186%20(20724)/results.html See <http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=css3%2Fbackground%2Fbackground-repeat-space-content.html>, which shows the image failure being introduced.

Radar WebKit Bug Importer

Comment 9 2015-01-27 16:49:39 PST

<rdar://problem/19623377>

WebKit Commit Bot

Comment 10 2015-01-31 19:47:17 PST

Re-opened since this is blocked by bug 141132

Andreas Kling

Comment 11 2015-02-02 13:25:21 PST

Committed r179494: <http://trac.webkit.org/changeset/179494>

WebKit Commit Bot

Comment 12 2015-02-09 11:48:04 PST

Re-opened since this is blocked by bug 141395

Alexey Proskuryakov

Comment 13 2015-02-27 15:56:31 PST

This also looks to have been breaking css3/background/background-repeat-space-content.html, see bug 140309.

Csaba Osztrogonác

Comment 14 2015-09-14 11:16:35 PDT

Comment on attachment 244350 [details] Patch Cleared Antti Koivisto's review+ from obsolete attachment 244350 [details] so that this bug does not appear in http://webkit.org/pending-commit.

Note You need to log in before you can comment on or make changes to this bug.