Bug 140288

Summary: Use angle-bracket form to include external headers in WebCore
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, tosha.Renee2.24.12, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140248    
Attachments:
Description Flags
Patch zan: review+

Carlos Garcia Campos
Reported 2015-01-09 02:05:12 PST
There are some cases using "" instead.
Attachments
Patch (9.17 KB, patch)
2015-01-09 02:06 PST, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-01-09 02:06:58 PST
Created attachment 244333 [details] Patch
WebKit Commit Bot
Comment 2 2015-01-09 02:08:33 PST
Attachment 244333 [details] did not pass style-queue: ERROR: Source/WebCore/platform/image-encoders/JPEGImageEncoder.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:39: "ANGLE/ShaderLang.h" already included at Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:36 [build/include] [4] Total errors found: 2 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 3 2015-01-09 02:42:16 PST
Comment on attachment 244333 [details] Patch Wait for the Mac EWSs please.
Carlos Garcia Campos
Comment 4 2015-01-09 03:46:57 PST
Committed r178166: <http://trac.webkit.org/changeset/178166>
Note You need to log in before you can comment on or make changes to this bug.