Bug 140288

Summary:

Use angle-bracket form to include external headers in WebCore

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, tosha.Renee2.24.12, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

140248

Attachments:

Description	Flags
Patch	zan: review+

Description Carlos Garcia Campos 2015-01-09 02:05:12 PST

There are some cases using "" instead.

Comment 1 Carlos Garcia Campos 2015-01-09 02:06:58 PST

Created attachment 244333 [details]
Patch

Comment 2 WebKit Commit Bot 2015-01-09 02:08:33 PST

Attachment 244333 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/image-encoders/JPEGImageEncoder.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:39:  "ANGLE/ShaderLang.h" already included at Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:36  [build/include] [4]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Zan Dobersek 2015-01-09 02:42:16 PST

Comment on attachment 244333 [details]
Patch

Wait for the Mac EWSs please.

Comment 4 Carlos Garcia Campos 2015-01-09 03:46:57 PST

Committed r178166: <http://trac.webkit.org/changeset/178166>