Bug 140287
| Summary: | [Regression] [GStreamer] Video player sets system volume to 100% | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Xabier Rodríguez Calvar <calvaris> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Major | CC: | adachan, allan.jensen, bugzilla, calvaris, commit-queue, eocanha, eric.carlson, esprehn+autocc, glenn, gustavo, jer.noble, jonathon, menard, mrobinson, patrakov, pnormand |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| URL: | http://www.w3.org/2010/05/video/mediaevents.html | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=145609 https://bugs.webkit.org/show_bug.cgi?id=140358 |
||
Xabier Rodríguez Calvar
+++ This bug was initially created as a clone of Bug #118974 +++
+++ This bug was initially created as a clone of Bug #54140 +++
This is back as a consequence of fixing bug 137305. I guess this time we should end up creating a test so that this doesn't regress anymore.
The proper fix would be reverting my original patch and fix it by using the new Browsers API at Pulseaudio but for that we need to have it implemented there and adapted in GStreamer, so I guess we'll have to fix this the same way again without breaking bug 137305. We'd appreciate if Ada could provide info about which test covers her fix so that we ensure we don't break anything again.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Xabier Rodríguez Calvar
This is being talked in Epiphany's bugzilla at https://bugzilla.gnome.org/show_bug.cgi?id=675217
Jer Noble
(In reply to comment #0)
> +++ This bug was initially created as a clone of Bug #118974 +++
>
> +++ This bug was initially created as a clone of Bug #54140 +++
>
> This is back as a consequence of fixing bug 137305. I guess this time we
> should end up creating a test so that this doesn't regress anymore.
>
> The proper fix would be reverting my original patch and fix it by using the
> new Browsers API at Pulseaudio but for that we need to have it implemented
> there and adapted in GStreamer, so I guess we'll have to fix this the same
> way again without breaking bug 137305. We'd appreciate if Ada could provide
> info about which test covers her fix so that we ensure we don't break
> anything again.
The original change broke a WebKitAPI test, which I don't believe are run as a part of normal EWS or post-commit tests. But they can be run manually with: `run-api-tests WebKit2.WKPageIsPlayingAudio`
Ada Chan
There is no layout test for https://bugs.webkit.org/show_bug.cgi?id=137305, since there's no simple way to test whether the page has really been muted.
The way I tested the fix for https://bugs.webkit.org/show_bug.cgi?id=137305 was just with this simple html page:
<div id=target style="border: solid;">
<video src="http://movies.apple.com/movies/us/apple/ipoditunes/2007/touch/ads/apple_ipodtouch_touch_r640-9cie.mov" autoplay controls></video>
</div>
And then call WKPageSetMuted(pageRef, true) and make sure the page is indeed silent.
Xabier Rodríguez Calvar
I couldn't reproduce the bug so I am closing it.