Bug 140285

Summary: [CoordinatedGraphics] Suspend or resume when visibility is changed
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Ryuan Choi 2015-01-08 21:14:21 PST 
When webview became hidden, I think that we don't need to draw something like TiledCoreAnimationDrawingArea in mac/
Comment 1 Ryuan Choi 2015-01-08 21:45:02 PST 
Created attachment 244326 [details]
Patch
Comment 2 Gyuyoung Kim 2015-01-08 21:49:27 PST 
Comment on attachment 244326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244326&action=review

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:613
> +    if (changed && ViewState::IsVisible) {

Is changed flag ? So don't we use below condition ?

if (changed & ViewState::IsVisible) {

}
Comment 3 Ryuan Choi 2015-01-08 22:24:16 PST 
Created attachment 244330 [details]
Patch
Comment 4 Ryuan Choi 2015-01-08 22:30:09 PST 
(In reply to comment #2)
> Comment on attachment 244326 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244326&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:613
> > +    if (changed && ViewState::IsVisible) {
> 
> Is changed flag ? So don't we use below condition ?
> 
> if (changed & ViewState::IsVisible) {
> 
> }

Oops, mistake.

Thanks for the review, I fixed.
Comment 5 WebKit Commit Bot 2015-01-11 18:47:05 PST 
Comment on attachment 244330 [details]
Patch

Clearing flags on attachment: 244330

Committed r178252: <http://trac.webkit.org/changeset/178252>
Comment 6 WebKit Commit Bot 2015-01-11 18:47:09 PST 
All reviewed patches have been landed.  Closing bug.