Bug 140285

Summary: [CoordinatedGraphics] Suspend or resume when visibility is changed
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2015-01-08 21:14:21 PST
When webview became hidden, I think that we don't need to draw something like TiledCoreAnimationDrawingArea in mac/
Attachments
Patch (2.67 KB, patch)
2015-01-08 21:45 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (2.67 KB, patch)
2015-01-08 22:24 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2015-01-08 21:45:02 PST
Created attachment 244326 [details] Patch
Gyuyoung Kim
Comment 2 2015-01-08 21:49:27 PST
Comment on attachment 244326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244326&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:613 > + if (changed && ViewState::IsVisible) { Is changed flag ? So don't we use below condition ? if (changed & ViewState::IsVisible) { }
Ryuan Choi
Comment 3 2015-01-08 22:24:16 PST
Created attachment 244330 [details] Patch
Ryuan Choi
Comment 4 2015-01-08 22:30:09 PST
(In reply to comment #2) > Comment on attachment 244326 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244326&action=review > > > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:613 > > + if (changed && ViewState::IsVisible) { > > Is changed flag ? So don't we use below condition ? > > if (changed & ViewState::IsVisible) { > > } Oops, mistake. Thanks for the review, I fixed.
WebKit Commit Bot
Comment 5 2015-01-11 18:47:05 PST
Comment on attachment 244330 [details] Patch Clearing flags on attachment: 244330 Committed r178252: <http://trac.webkit.org/changeset/178252>
WebKit Commit Bot
Comment 6 2015-01-11 18:47:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.