Bug 140283

Summary: Add basic pattern matching support to the url filters
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Benjamin Poulain
Reported 2015-01-08 20:42:31 PST
Add basic pattern matching support to the url filters
Attachments
Patch (32.85 KB, patch)
2015-01-08 20:56 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (33.84 KB, patch)
2015-01-09 14:07 PST, Benjamin Poulain 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2015-01-08 20:56:13 PST
Created attachment 244322 [details] Patch
Gavin Barraclough
Comment 2 2015-01-09 11:29:03 PST
Comment on attachment 244322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244322&action=review > Source/WebCore/contentextensions/URLFilterParser.cpp:140 > + void disjunction() { } Shouldn't these fail()?
Benjamin Poulain
Comment 3 2015-01-09 11:46:58 PST
(In reply to comment #2) > Comment on attachment 244322 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244322&action=review > > > Source/WebCore/contentextensions/URLFilterParser.cpp:140 > > + void disjunction() { } > > Shouldn't these fail()? I can add that. I was just implementing the minimum I need at the moment. Eventually everything except backreference should have an implementation.
Benjamin Poulain
Comment 4 2015-01-09 14:07:53 PST
Created attachment 244370 [details] Patch
Andreas Kling
Comment 5 2015-01-09 16:51:43 PST
Comment on attachment 244370 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244370&action=review r=me > Source/WebCore/contentextensions/URLFilterParser.cpp:70 > + ASSERT(isASCII(character)); I think this needs a runtime check, there's no guarantee that 'character' will be ASCII.
Benjamin Poulain
Comment 6 2015-01-12 17:37:21 PST
Committed r178313: <http://trac.webkit.org/changeset/178313>
Note You need to log in before you can comment on or make changes to this bug.