| Summary: | http/tests/misc/acid3.html is flakey on Mavericks | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
| Component: | Layout and Rendering | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, dino, jonlee, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 139968 | ||||||
| Attachments: |
|
||||||
|
Description
Myles C. Maxfield
2015-01-08 10:12:57 PST
This is caused by <rdar://problem/19433490> Created attachment 244397 [details]
Patch
Comment on attachment 244397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244397&action=review Nice detective work! > Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:169 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1090 Is this 10.9 only? My guess is that we need the workaround on 10.9 and later now. > Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:170 > + // Workaround <rdar://problem/19433490> "Work around" is two words when one of them is a verb, and also please add a period at the end. > LayoutTests/platform/mac/TestExpectations:-1492 > -webkit.org/b/139968 [ Mavericks+ ] http/tests/misc/acid3.html [ Pass Failure ] Here's hoping that this fixes more tests, but that can be cleaned up later. Comment on attachment 244397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244397&action=review >> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:169 >> +#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1090 > > Is this 10.9 only? My guess is that we need the workaround on 10.9 and later now. I tried in 10.10 and the bug did not present itself. >> LayoutTests/platform/mac/TestExpectations:-1492 >> -webkit.org/b/139968 [ Mavericks+ ] http/tests/misc/acid3.html [ Pass Failure ] > > Here's hoping that this fixes more tests, but that can be cleaned up later. Yeah, I need to figure that out and (hopefully) unskip more tests Hmm. But the test is also flaky on Yosemite, so we can't unmark it if the workaround is 10.9 only. http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmisc%2Facid3.html Comment on attachment 244397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244397&action=review >>> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:169 >>> +#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1090 >> >> Is this 10.9 only? My guess is that we need the workaround on 10.9 and later now. > > I tried in 10.10 and the bug did not present itself. That’s strange, given that the Apple team responsible does not claim the bug is fixed in 10.10 and is working on a fix for a future release. Committed r178513: <http://trac.webkit.org/changeset/178513> |