Summary: | Web Inspector: Editing Inline Styles Not Working | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Brian Burg <burg> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | burg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2015-01-07 20:37:25 PST
Regression caused by "purge PassRefPtr from Inspector code and use Ref for typed and untyped protocol objects": http://trac.webkit.org/changeset/178060 Doh. Looks like this was due to an InspectorStyleSheet change: - RefPtr<Inspector::InspectorValue> ordinalValue = value->get("ordinal"); - if (!ordinalValue || !ordinalValue->asInteger(m_ordinal)) + int ordinalValue; + if (!value->getInteger("ordinal", ordinalValue)) m_ordinal used to be getting set, but now it isn't, causing it to have a garbage value. Created attachment 244240 [details]
Patch
Comment on attachment 244240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244240&action=review Thanks! > Source/WebCore/inspector/InspectorStyleSheet.h:69 > - if (!value->getString("styleSheetId", m_styleSheetId)) > + if (!value->getString(ASCIILiteral("styleSheetId"), m_styleSheetId)) > return; > > - int ordinalValue; > - if (!value->getInteger("ordinal", ordinalValue)) > - m_styleSheetId = ""; > + if (!value->getInteger(ASCIILiteral("ordinal"), m_ordinal)) > + m_styleSheetId = String(); We could swap the order of these and avoid this awkward cleanup. (In reply to comment #5) > Comment on attachment 244240 [details] > Patch > > We could swap the order of these and avoid this awkward cleanup. Bah, then we'd need to clean up ordinal. I guess we do need awkwardness. Comment on attachment 244240 [details] Patch Clearing flags on attachment: 244240 Committed r178105: <http://trac.webkit.org/changeset/178105> All reviewed patches have been landed. Closing bug. |