Bug 140232

Summary:

Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, esprehn+autocc, glenn, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	andersca: review+

Description Dean Jackson 2015-01-07 17:06:13 PST

Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page

Comment 1 Dean Jackson 2015-01-07 17:06:36 PST

<rdar://problem/19371010>

Comment 2 Dean Jackson 2015-01-07 17:10:14 PST

Created attachment 244225 [details]
Patch

Comment 3 Dean Jackson 2015-01-07 17:23:22 PST

Comment on attachment 244225 [details]
Patch

Hold on this. Anders says I should nuke it (nearly) all.

Comment 4 Dean Jackson 2015-01-08 11:56:23 PST

Created attachment 244279 [details]
Patch

Comment 5 Dean Jackson 2015-01-08 12:25:10 PST

Committed r178124: <http://trac.webkit.org/changeset/178124>

Comment 6 Brent Fulgham 2015-01-08 13:29:53 PST

Whoops! Missed a couple.

Windows build fix committed in r178130. <http://trac.webkit.org/changeset/178130>.

Comment 7 Brent Fulgham 2015-01-08 13:56:05 PST

... and an extra symbol:

Another Windows build fix committed in r178131. <http://trac.webkit.org/changeset/178131>.