WKWebView crashes on deallocation

• Component: WebKit2
• Status: RESOLVED FIXED

[Eugene But]

Created attachment 244195 [details]
Test App

Summary:
[Chrome] WKWebView crashes on deallocation if it has pending JavaScript evaluation.

Steps to Reproduce:
1. Unarchive WKWebView.zip
2. Build and run test project on device or simulator


Expected Results:
"No error" should appear in console

Actual Results:
App crashes

[Eugene But]

Created attachment 244196 [details]
Crash Log

[Eugene But]

Radar ID: 19036018

[Simon Fraser (smfr)]

*** Bug 140915 has been marked as a duplicate of this bug. ***

[Simon Fraser (smfr)]

Created attachment 245398 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 245398 [details]
Patch

Sam said Yeah.

[WebKit Commit Bot]

Attachment 245398 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:45:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

https://trac.webkit.org/r179161 and https://trac.webkit.org/r179160 (OOPS!)

[Stuart Morgan]

Thanks! Is there any reasonable way for us to work around this in versions of the OS that don't have the fix?

[Simon Fraser (smfr)]

Try calling -copy on the completion block that you send into -[WKWebView evaluateJavaScript:completionHandler:], and manage the lifetime of the resulting block yourself.

[chenwenhong]

Hi，I fixed the WebKit's bug. The code below:

- (void)evaluateJavaScript:(NSString *)javaScriptString completionHandler:(void (^)(id, NSError *))completionHandler
{
    id strongSelf = self;
    
    [super evaluateJavaScript:javaScriptString completionHandler:^(id r, NSError *e) {
        [strongSelf title];
        
        if (completionHandler) {
            completionHandler(r, e);
        }
    }];
}