Bug 140184

Summary:

[Win] WindowCloseTimer is an ActiveDOMObject and must call suspendIfNeeded

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Major

CC:

achristensen, bfulgham, peavo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

53733

Bug Blocks:

Attachments:

Description	Flags
Patch	jer.noble: review+

Description Brent Fulgham 2015-01-07 10:19:26 PST

The Windows port has (for some time now) been improperly constructing its WindowCloseTimer objects. Ever since Bug 53733, ActiveDOMObjects have been required to call suspendIfNeeded so that DOM objects are in their proper state during script execution.

Comment 1 Radar WebKit Bug Importer 2015-01-07 10:20:20 PST

<rdar://problem/19399740>

Comment 2 Brent Fulgham 2015-01-07 10:23:57 PST

Created attachment 244161 [details]
Patch

Comment 3 Brent Fulgham 2015-01-07 10:33:50 PST

Committed r178041: <http://trac.webkit.org/changeset/178041>