Bug 140165 – interpret op_profile_type in the LLInt instead of unconditionally calling into the slow path

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Saam Barati]

Interpreting op_profile_type in the LLInt unconditionally calls into a slow path, but it should instead directly interpret op_profile_type and only call into the slow path when the TypeProfilerLog is full.

[Saam Barati]

Created attachment 244201 [details]
patch

[Michael Saboff]

Comment on attachment 244201 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244201&action=review

r=me

> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:623
> +    vm.typeProfilerLog()->processLogEntries(ASCIILiteral("LLInt log full."));

You might want to change the string to simply "log full".  I assume we'll expand this to at least the baseline JIT.

[Saam Barati]

Created attachment 244221 [details]
patch

Fixed bug on 32-bit asm. loadisFromInstrution had the wrong index.

[Saam Barati]

> You might want to change the string to simply "log full".  I assume we'll
> expand this to at least the baseline JIT.

The baseline JIT calls into a different operation when the log is full, passing a string indicating the log filled up while inside the baseline JIT. It's nice, when viewing performance of the log, to determine where TypeProfilerLog::processLogEntries is being called from.

[WebKit Commit Bot]

Comment on attachment 244221 [details]
patch

Clearing flags on attachment: 244221

Committed r178073: <http://trac.webkit.org/changeset/178073>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.