Summary: | Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Anders Carlsson
2015-01-06 12:21:09 PST
Created attachment 244089 [details]
Patch
Comment on attachment 244089 [details]
Patch
r=me
Committed r177986: <http://trac.webkit.org/changeset/177986> Comment on attachment 244089 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244089&action=review > Source/WebKit/mac/Plugins/npapi.mm:184 > + dispatch_async(dispatch_get_main_queue(), ^{ > + if (!pluginView || !pluginView->plugin) { > + // The plug-in has already been destroyed. > + return; > + } > + > + func(userData); > + }); Whether pluginView is null or not is already known before calling dispatch_async so that check seems like it should be outside the block. |