Bug 140140

Summary: Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2015-01-06 12:21:09 PST
Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
Attachments
Patch (4.11 KB, patch)
2015-01-06 12:22 PST, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-01-06 12:22:49 PST
Created attachment 244089 [details] Patch
Andreas Kling
Comment 2 2015-01-06 12:42:42 PST
Comment on attachment 244089 [details] Patch r=me
Anders Carlsson
Comment 3 2015-01-06 12:43:24 PST
Committed r177986: <http://trac.webkit.org/changeset/177986>
Darin Adler
Comment 4 2015-01-06 14:26:48 PST
Comment on attachment 244089 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244089&action=review > Source/WebKit/mac/Plugins/npapi.mm:184 > + dispatch_async(dispatch_get_main_queue(), ^{ > + if (!pluginView || !pluginView->plugin) { > + // The plug-in has already been destroyed. > + return; > + } > + > + func(userData); > + }); Whether pluginView is null or not is already known before calling dispatch_async so that check seems like it should be outside the block.
Note You need to log in before you can comment on or make changes to this bug.