Summary: | MultiGetByOffset should be marked NodeMustGenerate | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Filip Pizlo
2015-01-06 11:51:21 PST
Created attachment 245919 [details]
the patch
Comment on attachment 245919 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=245919&action=review r=me with spelling fixes in ChangeLog. > Source/JavaScriptCore/ChangeLog:10 > + (JSC::DFG::Node::convertToMultiGetByOffset): Assert that we converted from something that alraedy had NodeMustGenerate. *already* > Source/JavaScriptCore/ChangeLog:11 > + * dfg/DFGNodeType.h: We shouldn't DCE a node that does checks and could be effectful in bseline. Making MultiGetBYoffset as NodeMustGenerate prevents DCE. FTL could still DCE the actual loads, but the checks will stay. *baseline* (In reply to comment #2) > Comment on attachment 245919 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245919&action=review > > r=me with spelling fixes in ChangeLog. > > > Source/JavaScriptCore/ChangeLog:10 > > + (JSC::DFG::Node::convertToMultiGetByOffset): Assert that we converted from something that alraedy had NodeMustGenerate. > > *already* > > > Source/JavaScriptCore/ChangeLog:11 > > + * dfg/DFGNodeType.h: We shouldn't DCE a node that does checks and could be effectful in bseline. Making MultiGetBYoffset as NodeMustGenerate prevents DCE. FTL could still DCE the actual loads, but the checks will stay. > > *baseline* Thanks! Fixed both locally. Landed in http://trac.webkit.org/changeset/179536 |