Bug 140133

Summary:

Move the Windows only plug-in code to WebKit/win

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cgarcia, commit-queue, japhet, mrobinson, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Anders Carlsson

Reported 2015-01-06 11:08:50 PST

Move the Windows only plug-in code to WebKit/win

Attachments
Patch (476.74 KB, patch) 2015-01-06 11:09 PST, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (477.23 KB, patch) 2015-01-06 12:18 PST, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (478.25 KB, patch) 2015-01-06 13:50 PST, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (478.77 KB, patch) 2015-01-06 14:52 PST, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (482.00 KB, patch) 2015-01-07 12:01 PST, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (485.66 KB, patch) 2015-01-08 08:56 PST, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (486.62 KB, patch) 2015-01-09 14:54 PST, Anders Carlsson	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2015-01-06 11:09:24 PST

Created attachment 244076 [details] Patch

WebKit Commit Bot

Comment 2 2015-01-06 11:12:24 PST

Attachment 244076 [details] did not pass style-queue: ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:57: The parameter name "message" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:58: The parameter name "message" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.cpp:66: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit/win/Plugins/PluginDebug.cpp:83: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:47: Use 'using namespace std;' instead of 'using std::max;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:48: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:201: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:254: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:296: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:296: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:333: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:339: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:350: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:479: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:96: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:96: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:111: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:133: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:153: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:52: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:171: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:176: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:177: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:103: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:242: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:245: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:307: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:335: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:347: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:347: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:348: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:352: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:352: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:368: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:667: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:667: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:668: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:673: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:684: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:687: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:699: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:811: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:829: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:843: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:902: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:934: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:66: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginView.h:117: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:128: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:155: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:155: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:156: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:157: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:157: The parameter name "reason" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:166: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:167: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:168: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:169: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:170: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:200: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:277: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:278: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:399: The parameter name "event" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:53: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.h:54: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginQuirkSet.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginQuirkSet.h:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:40: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:42: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:43: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:44: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:47: The parameter name "drawingModel" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:48: The parameter name "eventModel" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:206: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:36: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:38: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:66: The parameter name "a" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:85: The parameter name "mimeDescription" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.cpp:126: Declaration has space between type name and * in PluginMessage *message [whitespace/declaration] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:70: The parameter name "plugin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:88: The parameter name "persistentMetadataCachePath" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:89: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:253: Use 0 instead of NULL. [readability/null] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:638: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:654: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:678: Weird number of spac es at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:988: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:986: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:991: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1009: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1077: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1092: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1093: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1093: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1133: Missing space before ( in if( [whitespace/parens] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1246: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:162: map_it is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:163: map_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:243: mime_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:245: mime_it is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:572: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:573: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:574: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:643: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:644: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:645: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 133 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 3 2015-01-06 12:18:46 PST

Created attachment 244088 [details] Patch

WebKit Commit Bot

Comment 4 2015-01-06 12:22:29 PST

Attachment 244088 [details] did not pass style-queue: ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:57: The parameter name "message" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:58: The parameter name "message" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.cpp:66: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit/win/Plugins/PluginDebug.cpp:83: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:47: Use 'using namespace std;' instead of 'using std::max;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:48: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:201: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:254: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:296: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:296: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:333: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:339: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:350: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:479: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:96: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:96: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:111: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:133: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:153: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:52: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:171: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:176: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:177: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:103: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:242: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:245: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:307: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:335: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:347: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:347: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:348: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:352: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:352: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:368: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:667: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:667: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:668: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:673: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:684: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:687: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:699: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:811: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:829: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:843: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:902: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:934: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:66: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginView.h:117: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:128: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:155: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:155: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:156: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:157: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:157: The parameter name "reason" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:166: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:167: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:168: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:169: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:170: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:200: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:277: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:278: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:399: The parameter name "event" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:53: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.h:54: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginQuirkSet.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginQuirkSet.h:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:40: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:42: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:43: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:44: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:47: The parameter name "drawingModel" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:48: The parameter name "eventModel" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:206: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:36: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:38: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:66: The parameter name "a" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:85: The parameter name "mimeDescription" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.cpp:126: Declaration has space between type name and * in PluginMessage *message [whitespace/declaration] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:89: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:253: Use 0 instead of NULL. [readability/null] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:638: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:654: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:678: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:988: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:986: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:99 1: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1009: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1077: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1092: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1093: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1093: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1133: Missing space before ( in if( [whitespace/parens] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1246: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:70: The parameter name "plugin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:88: The parameter name "persistentMetadataCachePath" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:162: map_it is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:163: map_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:243: mime_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:245: mime_it is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:572: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:573: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:574: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:643: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:644: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:645: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 133 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 5 2015-01-06 13:50:02 PST

Created attachment 244094 [details] Patch

WebKit Commit Bot

Comment 6 2015-01-06 13:52:00 PST

Attachment 244094 [details] did not pass style-queue: ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:57: The parameter name "message" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:58: The parameter name "message" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.cpp:66: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit/win/Plugins/PluginDebug.cpp:83: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:47: Use 'using namespace std;' instead of 'using std::max;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:48: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:201: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:254: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:296: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:296: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:333: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:339: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:350: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:479: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:96: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:96: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:111: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:133: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:153: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:52: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:171: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:176: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:177: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:162: map_it is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:163: map_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:243: mime_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:245: mime_it is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:572: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:573: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:574: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:643: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:644: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:645: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:103: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:242: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:245: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:307: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:335: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:347: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:347: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:348: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:352: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:352: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:368: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:667: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:667: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:668: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:673: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:684: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:687: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:699: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:811: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:829: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:843: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:902: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:934: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:66: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginView.h:117: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:128: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:155: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:155: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:156: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:157: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:157: The parameter name "reason" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:166: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:167: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:168: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:169: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:170: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:200: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:277: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:278: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:399: The parameter name "event" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:53: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.h:54: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginQuirkSet.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginQuirkSet.h:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.cpp:126: Declaration has space between type name and * in PluginMessage *message [whitespace/declaration] [3] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:40: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:42: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:43: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:44: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:47: The parameter name "drawingModel" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:48: The parameter name "eventModel" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:206: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:36: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:38: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins /npapi.cpp:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:66: The parameter name "a" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:85: The parameter name "mimeDescription" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:89: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:253: Use 0 instead of NULL. [readability/null] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:638: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:654: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:678: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:988: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:986: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:991: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1009: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1077: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1092: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1093: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1093: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1133: Missing space before ( in if( [whitespace/parens] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1246: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:70: The parameter name "plugin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:88: The parameter name "persistentMetadataCachePath" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 133 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Csaba Osztrogonác

Comment 7 2015-01-06 14:14:22 PST

(In reply to comment #0) > Move the Windows only plug-in code to WebKit/win There are many GTK guarded code in the proposed patch, I don't think if these code should be moved into WebKit/win.

Martin Robinson

Comment 8 2015-01-06 14:17:30 PST

If this GTK+-guraded code is only used in WebKit1, it can probably be removed completely. I imagine it's left over from the WebKitGTK+ WebKit1 port for Windows.

Anders Carlsson

Comment 9 2015-01-06 14:39:12 PST

(In reply to comment #8) > If this GTK+-guraded code is only used in WebKit1, it can probably be > removed completely. I imagine it's left over from the WebKitGTK+ WebKit1 > port for Windows. Or the WebKitGTK+ WebKit1 port altogether.

Anders Carlsson

Comment 10 2015-01-06 14:52:53 PST

Created attachment 244098 [details] Patch

WebKit Commit Bot

Comment 11 2015-01-06 14:55:22 PST

Attachment 244098 [details] did not pass style-queue: ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:57: The parameter name "message" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:58: The parameter name "message" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.cpp:66: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit/win/Plugins/PluginDebug.cpp:83: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:47: Use 'using namespace std;' instead of 'using std::max;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:48: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:201: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:254: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:296: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:296: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:333: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:339: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:350: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:479: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:96: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:96: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:111: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:133: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:153: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:52: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:171: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:176: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:177: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:162: map_it is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:163: map_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:243: mime_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:245: mime_it is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:572: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:573: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:574: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:643: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:644: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:645: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:103: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:242: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:245: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:307: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:335: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:347: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:347: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:348: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:352: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:352: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:368: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:667: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:667: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:668: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:673: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:684: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:687: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:699: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:811: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:829: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:843: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:902: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:934: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:66: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginView.h:117: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:128: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:155: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:155: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:156: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:157: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:157: The parameter name "reason" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:166: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:167: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:168: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:169: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:170: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:200: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:277: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:278: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:399: The parameter name "event" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:53: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.h:54: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginQuirkSet.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginQuirkSet.h:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.cpp:126: Declaration has space between type name and * in PluginMessage *message [whitespace/declaration] [3] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:40: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:42: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:43: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:44: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:47: The parameter name "drawingModel" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:48: The parameter name "eventModel" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:206: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:36: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:38: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins /npapi.cpp:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:66: The parameter name "a" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:85: The parameter name "mimeDescription" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:89: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:253: Use 0 instead of NULL. [readability/null] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:638: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:654: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:678: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:988: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:986: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:991: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1009: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1077: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1092: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1093: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1093: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1133: Missing space before ( in if( [whitespace/parens] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1246: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:70: The parameter name "plugin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:88: The parameter name "persistentMetadataCachePath" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 133 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Carlos Garcia Campos

Comment 12 2015-01-07 01:00:32 PST

All the GTK specific code there are indeed leftovers, the WebKit1 GTK port was removed from trunk already, so it's safe to remove all that code.

Anders Carlsson

Comment 13 2015-01-07 12:01:14 PST

Created attachment 244171 [details] Patch

WebKit Commit Bot

Comment 14 2015-01-07 12:03:49 PST

Attachment 244171 [details] did not pass style-queue: ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:57: The parameter name "message" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:58: The parameter name "message" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.cpp:66: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit/win/Plugins/PluginDebug.cpp:83: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:47: Use 'using namespace std;' instead of 'using std::max;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:48: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:201: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:254: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:296: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:296: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:333: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:339: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:350: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:479: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:96: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:96: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:111: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:133: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:153: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:52: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:171: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:176: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:177: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:162: map_it is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:163: map_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:243: mime_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:245: mime_it is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:572: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:573: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:574: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:643: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:644: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:645: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:103: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:242: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:245: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:307: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:335: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:347: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:347: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:348: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:352: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:352: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:368: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:667: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:667: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:668: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:673: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:684: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:687: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:699: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:811: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:829: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:843: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:902: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:934: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:66: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginView.h:117: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:128: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:155: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:155: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:156: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:157: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:157: The parameter name "reason" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:166: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:167: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:168: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:169: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:170: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:200: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:277: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:278: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:399: The parameter name "event" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:53: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.h:54: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginQuirkSet.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginQuirkSet.h:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.cpp:126: Declaration has space between type name and * in PluginMessage *message [whitespace/declaration] [3] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:40: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:42: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:43: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:44: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:47: The parameter name "drawingModel" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:48: The parameter name "eventModel" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:206: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:36: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:38: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:42: Code inside a namespace sho uld not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:66: The parameter name "a" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:85: The parameter name "mimeDescription" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:89: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:253: Use 0 instead of NULL. [readability/null] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:638: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:654: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:678: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:988: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:986: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:991: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1009: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1077: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1092: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1093: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1093: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1133: Missing space before ( in if( [whitespace/parens] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1246: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:70: The parameter name "plugin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:88: The parameter name "persistentMetadataCachePath" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 130 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 15 2015-01-08 08:56:45 PST

Created attachment 244264 [details] Patch

WebKit Commit Bot

Comment 16 2015-01-08 09:00:00 PST

Attachment 244264 [details] did not pass style-queue: ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:57: The parameter name "message" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:58: The parameter name "message" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.cpp:66: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit/win/Plugins/PluginDebug.cpp:83: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:47: Use 'using namespace std;' instead of 'using std::max;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:48: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:201: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:254: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:296: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:296: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:333: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:339: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:350: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:479: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:96: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:96: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:111: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:133: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:153: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:52: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:171: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:176: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:177: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:162: map_it is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:163: map_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:243: mime_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:245: mime_it is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:572: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:573: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:574: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:643: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:644: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:645: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:59: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:103: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:242: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:245: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:307: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:335: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:347: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:347: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:348: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:352: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:352: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:368: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:667: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:667: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:668: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:673: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:684: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:687: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:699: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:811: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:829: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:843: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:902: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:934: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:66: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginView.h:117: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:128: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:155: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:155: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:156: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:157: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:157: The parameter name "reason" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:166: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:167: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:168: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:169: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:170: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:200: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:277: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:278: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:399: The parameter name "event" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:53: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.h:54: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginQuirkSet.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginQuirkSet.h:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.cpp:126: Declaration has space between type name and * in PluginMessage *message [whitespace/declaration] [3] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:40: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:42: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:43: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:44: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:47: The parameter name "drawingModel" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:48: The parameter name "eventModel" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:206: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:36: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:38: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:156: Weird number of spaces at line-start. Ar e you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:66: The parameter name "a" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:85: The parameter name "mimeDescription" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:89: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:253: Use 0 instead of NULL. [readability/null] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:638: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:654: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:678: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:988: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:986: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:991: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1009: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1077: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1092: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1093: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1093: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1133: Missing space before ( in if( [whitespace/parens] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1246: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:70: The parameter name "plugin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:88: The parameter name "persistentMetadataCachePath" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 131 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 17 2015-01-08 09:16:07 PST

Comment on attachment 244264 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244264&action=review r=me assuming the Windows build succeeds > Source/WebKit/win/Plugins/PluginDatabase.cpp:378 > +#if (!OS(WINDOWS) || !ENABLE(NETSCAPE_PLUGIN_API)) Can we make this Windows-specific now that we are moving it? Seems unnecessary to check OS(WINDOWS). > Source/WebKit/win/Plugins/PluginDatabase.cpp:388 > +#if defined(XP_UNIX) Or to check XP_UNIX. > Source/WebKit/win/Plugins/PluginDatabase.cpp:424 > +#elif defined(XP_MACOSX) Or XP_MACOSX. > Source/WebKit/win/Plugins/PluginDatabase.cpp:429 > +#elif defined(XP_WIN) Or XP_WIN.

Anders Carlsson

Comment 18 2015-01-08 09:24:57 PST

(In reply to comment #17) > Comment on attachment 244264 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244264&action=review > > r=me assuming the Windows build succeeds > > > Source/WebKit/win/Plugins/PluginDatabase.cpp:378 > > +#if (!OS(WINDOWS) || !ENABLE(NETSCAPE_PLUGIN_API)) > > Can we make this Windows-specific now that we are moving it? Seems > unnecessary to check OS(WINDOWS). Yeah, there's a lot of cleanup to be done here once everything has been moved successfully.

Anders Carlsson

Comment 19 2015-01-09 14:54:03 PST

Created attachment 244375 [details] Patch

WebKit Commit Bot

Comment 20 2015-01-09 14:56:07 PST

Attachment 244375 [details] did not pass style-queue: ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:57: The parameter name "message" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.h:58: The parameter name "message" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.cpp:66: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit/win/Plugins/PluginDebug.cpp:83: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:47: Use 'using namespace std;' instead of 'using std::max;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:48: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:201: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:254: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:296: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:296: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:333: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:339: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:350: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.cpp:479: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:96: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:96: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:111: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:133: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabaseWin.cpp:153: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:52: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:171: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:176: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginPackageWin.cpp:177: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:162: map_it is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:163: map_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:243: mime_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:245: mime_it is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:572: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:573: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:574: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:643: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:644: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:645: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginDatabase.cpp:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:59: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:103: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:242: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:245: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:307: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:335: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:347: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:347: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:348: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:352: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:352: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:368: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:667: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:667: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:668: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:673: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:684: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:687: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:699: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:811: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:829: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:843: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:902: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginViewWin.cpp:934: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:66: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginView.h:117: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:128: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.h:155: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:155: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:156: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:157: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:157: The parameter name "reason" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:166: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:167: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:168: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:169: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:170: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:200: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:277: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:278: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.h:399: The parameter name "event" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginStream.h:53: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginStream.h:54: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebKit/win/Plugins/PluginQuirkSet.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginQuirkSet.h:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginMessageThrottlerWin.cpp:126: Declaration has space between type name and * in PluginMessage *message [whitespace/declaration] [3] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:40: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:42: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:43: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:44: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:47: The parameter name "drawingModel" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDebug.h:48: The parameter name "eventModel" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginPackage.cpp:206: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:36: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:38: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/npapi.cpp:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/npapi.cpp:156: Weird number of spaces at line-start. Ar e you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:66: The parameter name "a" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginPackage.h:85: The parameter name "mimeDescription" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:89: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:253: Use 0 instead of NULL. [readability/null] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:638: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:654: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:678: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:988: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:986: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:991: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1009: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1072: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1077: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1092: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1093: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1093: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1133: Missing space before ( in if( [whitespace/parens] [5] ERROR: Source/WebKit/win/Plugins/PluginView.cpp:1246: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:70: The parameter name "plugin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/win/Plugins/PluginDatabase.h:88: The parameter name "persistentMetadataCachePath" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 131 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 21 2015-01-09 16:16:52 PST

Committed r178219: <http://trac.webkit.org/changeset/178219>

Brent Fulgham

Comment 22 2015-01-09 17:23:43 PST

This actually breaks Windows builds if you do a full rebuild (such that there is no longer a pre-assembled PaintHooks.asm->PainHooks.obj) file in the build directory. Fix committed in r178225: <http://trac.webkit.org/changeset/178225>

Note You need to log in before you can comment on or make changes to this bug.