Bug 140124

Summary: Rename SimpleFontData::AdditionalFontData to SimpleFontData::SVGData
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, kondapallykalyan, mmaxfield, pdr, schenney, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 135290    
Attachments:
Description Flags
patch andersca: review+

Description Antti Koivisto 2015-01-06 07:32:34 PST 
The current name is vague and confusing.
Comment 1 Antti Koivisto 2015-01-06 07:45:40 PST 
Created attachment 244061 [details]
patch
Comment 2 Myles C. Maxfield 2015-01-06 09:39:37 PST 
Comment on attachment 244061 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244061&action=review

> Source/WebCore/platform/graphics/SimpleFontData.h:179
> +    bool isSVGFont() const { return !!m_svgData; }

Is the !! necessary? Won't the bool cast be automatic?
Comment 3 Anders Carlsson 2015-01-06 09:41:38 PST 
Comment on attachment 244061 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244061&action=review

>> Source/WebCore/platform/graphics/SimpleFontData.h:179
>> +    bool isSVGFont() const { return !!m_svgData; }
> 
> Is the !! necessary? Won't the bool cast be automatic?

It won't since the std::unique_ptr bool operator is explicit.
Comment 4 Antti Koivisto 2015-01-06 11:22:12 PST 
https://trac.webkit.org/r177975