Bug 140124

Summary: Rename SimpleFontData::AdditionalFontData to SimpleFontData::SVGData
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, kondapallykalyan, mmaxfield, pdr, schenney, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 135290    
Attachments:
Description Flags
patch andersca: review+

Antti Koivisto
Reported 2015-01-06 07:32:34 PST
The current name is vague and confusing.
Attachments
patch (10.43 KB, patch)
2015-01-06 07:45 PST, Antti Koivisto 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2015-01-06 07:45:40 PST
Created attachment 244061 [details] patch
Myles C. Maxfield
Comment 2 2015-01-06 09:39:37 PST
Comment on attachment 244061 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=244061&action=review > Source/WebCore/platform/graphics/SimpleFontData.h:179 > + bool isSVGFont() const { return !!m_svgData; } Is the !! necessary? Won't the bool cast be automatic?
Anders Carlsson
Comment 3 2015-01-06 09:41:38 PST
Comment on attachment 244061 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=244061&action=review >> Source/WebCore/platform/graphics/SimpleFontData.h:179 >> + bool isSVGFont() const { return !!m_svgData; } > > Is the !! necessary? Won't the bool cast be automatic? It won't since the std::unique_ptr bool operator is explicit.
Antti Koivisto
Comment 4 2015-01-06 11:22:12 PST
https://trac.webkit.org/r177975
Note You need to log in before you can comment on or make changes to this bug.