Bug 140113

Summary:

Make explicit which TextIndicator animations are driven manually, and which run automatically

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Tim Horton 2015-01-05 23:14:03 PST

Make explicit which TextIndicator animations are driven manually, and which run automatically

Comment 1 Radar WebKit Bug Importer 2015-01-05 23:14:43 PST

<rdar://problem/19383425>

Comment 2 Radar WebKit Bug Importer 2015-01-05 23:14:47 PST

<rdar://problem/19383427>

Comment 3 Tim Horton 2015-01-05 23:16:09 PST

Created attachment 244035 [details]
Patch

Comment 4 Darin Adler 2015-01-06 01:45:03 PST

Comment on attachment 244035 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244035&action=review

> Source/WebCore/page/TextIndicator.cpp:262
> +    return false;

I think we should have ASSERT_NOT_REACHED here.

Comment 5 Tim Horton 2015-01-06 11:10:27 PST

http://trac.webkit.org/changeset/177970