Bug 140106

Summary: Using calc() for -webkit-filter does not work
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, dino, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2015-01-05 17:13:45 PST
Using calc() for -webkit-filter does not work because the CSS parser does not handle it properly.
Comment 1 Chris Dumez 2015-01-05 17:18:01 PST
Created attachment 244019 [details]
Patch
Comment 2 Darin Adler 2015-01-05 20:17:28 PST
Comment on attachment 244019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244019&action=review

> Source/WebCore/css/CSSParser.cpp:9358
> +            Ref<CSSPrimitiveValue> primitiveValue = createPrimitiveNumericValue(argumentWithCalculation);

I like auto for this sort of thing.
Comment 3 Chris Dumez 2015-01-05 21:10:53 PST
Created attachment 244033 [details]
Patch
Comment 4 WebKit Commit Bot 2015-01-05 21:51:45 PST
Comment on attachment 244033 [details]
Patch

Clearing flags on attachment: 244033

Committed r177950: <http://trac.webkit.org/changeset/177950>
Comment 5 WebKit Commit Bot 2015-01-05 21:51:50 PST
All reviewed patches have been landed.  Closing bug.